Skip to content
Merged

Dev #108

Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
672 commits
Select commit Hold shift + click to select a range
a00ac69
Merge branch 'clair3_model_fix' into template_update
robert-a-forsyth Sep 1, 2025
ea3e40a
Merge branch 'template_update' of https://github.com/IntGenomicsLab/l…
robert-a-forsyth Sep 1, 2025
4fbbaa9
add brackets
robert-a-forsyth Sep 1, 2025
6bde8da
fix merge artifacts
robert-a-forsyth Sep 1, 2025
624b83e
linting
ljwharbers Sep 1, 2025
4707024
Merge pull request #80 from IntGenomicsLab/template_update
robert-a-forsyth Sep 1, 2025
c202169
Add vep
robert-a-forsyth Aug 25, 2025
5f74572
fix path
robert-a-forsyth Aug 25, 2025
bbb8fc8
fix fasta channel input clairs
robert-a-forsyth Aug 25, 2025
187a533
fix fai channel
robert-a-forsyth Aug 25, 2025
8ef1c24
Add sv vep
robert-a-forsyth Aug 25, 2025
60c7e35
fix fasta channels
robert-a-forsyth Aug 25, 2025
6640181
fix vep channel structure
robert-a-forsyth Aug 27, 2025
3525320
fix channel structure
robert-a-forsyth Aug 27, 2025
6ac0975
Add Vep configs
robert-a-forsyth Aug 28, 2025
6ce75de
fix VEP params
robert-a-forsyth Aug 28, 2025
9f9bbb4
fix params
robert-a-forsyth Aug 28, 2025
61c3fab
fix channel name typos
robert-a-forsyth Aug 28, 2025
17a7d85
add view
robert-a-forsyth Aug 29, 2025
9443553
change names
robert-a-forsyth Sep 2, 2025
ab233a1
fix
robert-a-forsyth Sep 2, 2025
a8e0357
change name
robert-a-forsyth Sep 2, 2025
10ceb54
skip_ascat test
robert-a-forsyth Sep 5, 2025
6900a25
big vep rework
robert-a-forsyth Sep 5, 2025
380f539
fix module paths
robert-a-forsyth Sep 5, 2025
2d3823a
fix vsc-copilots attempts at nextflow syntax
robert-a-forsyth Sep 5, 2025
9f836cb
fixing more copilot shit
robert-a-forsyth Sep 5, 2025
f1e1a69
add skips
robert-a-forsyth Sep 5, 2025
dde258c
fix param reference
robert-a-forsyth Sep 5, 2025
29ee636
remove help message
robert-a-forsyth Sep 5, 2025
901185b
fix cache references
robert-a-forsyth Sep 5, 2025
53887c6
more like sarek
robert-a-forsyth Sep 5, 2025
2a58426
add file I forgot to save
robert-a-forsyth Sep 5, 2025
b02b168
fix
robert-a-forsyth Sep 5, 2025
c5a328f
fix
robert-a-forsyth Sep 5, 2025
b801418
remove $
robert-a-forsyth Sep 5, 2025
d90ee55
fix vep cache reference
robert-a-forsyth Sep 5, 2025
1446da3
fix channel setup
robert-a-forsyth Sep 5, 2025
a9202fa
remove clair3 import
robert-a-forsyth Sep 5, 2025
86c2b4b
remove redundant clairS
robert-a-forsyth Sep 5, 2025
aaeaf5b
fix channel
robert-a-forsyth Sep 5, 2025
345cc3f
remove redunant vep references
robert-a-forsyth Sep 5, 2025
4c39b15
fix json
robert-a-forsyth Sep 9, 2025
1de0471
more better view command
robert-a-forsyth Sep 9, 2025
bab7e29
fix
robert-a-forsyth Sep 9, 2025
e8ae65f
spacing
robert-a-forsyth Sep 9, 2025
9184ce2
remove if
robert-a-forsyth Sep 9, 2025
9e5a8a0
fix if
robert-a-forsyth Sep 9, 2025
3f69425
fix aws path
robert-a-forsyth Sep 9, 2025
aa07a83
fix vep output path
robert-a-forsyth Sep 10, 2025
8d49dfd
add prefixes to vep modules
robert-a-forsyth Sep 11, 2025
e7ba647
fix version formatting
robert-a-forsyth Sep 11, 2025
a61f252
gzip severus
robert-a-forsyth Sep 11, 2025
4716d6b
fix severus path
robert-a-forsyth Sep 11, 2025
617665a
indexing longphase vcf
robert-a-forsyth Sep 11, 2025
c4ee1a6
fix tbi reference
robert-a-forsyth Sep 11, 2025
def9b47
fix bgziping
robert-a-forsyth Sep 11, 2025
bd73748
Update subworkflows/local/tumor_only_happhase.nf
robert-a-forsyth Sep 12, 2025
ecbad61
Update workflows/lr_somatic.nf
robert-a-forsyth Sep 12, 2025
ef72198
Update workflows/lr_somatic.nf
robert-a-forsyth Sep 12, 2025
7b27a3d
fix copilot suggestions
robert-a-forsyth Sep 12, 2025
040f062
Merge branch 'vep' of https://github.com/IntGenomicsLab/lr_somatic in…
robert-a-forsyth Sep 12, 2025
066af15
patch
robert-a-forsyth Sep 12, 2025
a6278ce
fix schema
robert-a-forsyth Sep 12, 2025
a12ea73
fix schema
robert-a-forsyth Sep 12, 2025
09cd7b5
fix test
robert-a-forsyth Sep 12, 2025
f3cdef1
precommit fix
robert-a-forsyth Sep 12, 2025
3e9499b
fix output
robert-a-forsyth Sep 12, 2025
3f8ed0d
Disable pubDir for longphase
robert-a-forsyth Sep 12, 2025
01ed021
minor changes
ljwharbers Sep 12, 2025
3310e70
mix versions
robert-a-forsyth Sep 12, 2025
66fa9cc
Remove vcfsplit TODO + add tbi outputs
robert-a-forsyth Sep 12, 2025
3727317
precommit
robert-a-forsyth Sep 12, 2025
54b2e81
linting
ljwharbers Sep 12, 2025
3ece198
remove whitespace
ljwharbers Sep 12, 2025
e85bedf
fix modules.config
ljwharbers Sep 12, 2025
4c37db4
Merge pull request #91 from IntGenomicsLab/vep
ljwharbers Sep 12, 2025
bba2705
Remove ANNOTSV_ANNOTSV import
robert-a-forsyth Sep 17, 2025
83ab8e3
Merge pull request #93 from IntGenomicsLab/robert-a-forsyth-patch-1
ljwharbers Sep 17, 2025
f2b0ac8
rename pipeline in yml
ljwharbers Sep 17, 2025
7a1a59f
Template update for nf-core/tools version 3.3.2
ljwharbers Sep 17, 2025
d207b0c
merge with updated template branch for renaming
ljwharbers Sep 17, 2025
2ccd7e2
remove _ in missed include statement
ljwharbers Sep 17, 2025
f4a3bd2
fix robert typo
ljwharbers Sep 17, 2025
4448c23
remove channel view
ljwharbers Sep 17, 2025
e880167
adjusting test profile
ljwharbers Sep 17, 2025
a4abd98
linting and trailing merge conflict
ljwharbers Sep 17, 2025
24939ce
remove required logo files
ljwharbers Sep 17, 2025
e23690e
remove required logo files
ljwharbers Sep 17, 2025
59f7602
update ro-crate
ljwharbers Sep 17, 2025
a5d1a9e
yml change
ljwharbers Sep 17, 2025
e399056
give custom vep genome for smaller cache download
ljwharbers Sep 18, 2025
5b0dad8
add test snapshot
ljwharbers Sep 18, 2025
05c22b3
Merge pull request #94 from IntGenomicsLab/renaming
robert-a-forsyth Sep 19, 2025
93784ef
new snap
ljwharbers Sep 22, 2025
847c5df
minor severus change to fix output dirs
ljwharbers Sep 22, 2025
7aa6e6d
added ignores and new test snapshot
ljwharbers Sep 22, 2025
c545fc4
added nftignore
ljwharbers Sep 23, 2025
bfc9b23
updated ignore and snap
ljwharbers Sep 23, 2025
fe7a65d
updated nftignore
ljwharbers Sep 23, 2025
4188702
linting
ljwharbers Sep 23, 2025
a2ceac6
remove prefix from severus output
ljwharbers Sep 23, 2025
b5484e0
update snap
ljwharbers Sep 23, 2025
c65898c
once again, updated snap and ignore list
ljwharbers Sep 23, 2025
f523fea
lowercase vep
ljwharbers Sep 23, 2025
cfd9080
updated snapshot
ljwharbers Sep 23, 2025
a66226e
Merge pull request #95 from IntGenomicsLab/CI_fix
ljwharbers Sep 24, 2025
d62e39a
fix laurens :)
ljwharbers Sep 26, 2025
a7d8abb
linting
ljwharbers Sep 26, 2025
158fc9a
add .nf-test to .gitignore
robert-a-forsyth Sep 26, 2025
eae3ac1
fix snapshot
ljwharbers Sep 26, 2025
596a9db
update gitignore
ljwharbers Sep 26, 2025
b85f985
linting
ljwharbers Sep 26, 2025
94dd751
added clean up in CI
ljwharbers Sep 26, 2025
a2d3f50
linting
ljwharbers Sep 26, 2025
843add8
Merge pull request #97 from IntGenomicsLab/fix_laurens
robert-a-forsyth Sep 29, 2025
11a73a0
fix clairsto pon
robert-a-forsyth Sep 29, 2025
7b4742b
fix clairsto pon
robert-a-forsyth Sep 29, 2025
e885a91
Merge branch 'clairstoPON' of https://github.com/IntGenomicsLab/lr_so…
robert-a-forsyth Sep 29, 2025
307bbaa
fix channel reference
robert-a-forsyth Sep 29, 2025
6ce8c79
Change nextflow schema
robert-a-forsyth Sep 29, 2025
b3cb632
revert schema
robert-a-forsyth Sep 29, 2025
3cf88f8
pon empty value channels add
robert-a-forsyth Sep 29, 2025
e1d1892
add webpath for grch38 pon
robert-a-forsyth Sep 29, 2025
076b5a0
update test
robert-a-forsyth Sep 29, 2025
833f396
add optional to wakhan tumor-only output
robert-a-forsyth Sep 30, 2025
84bf872
remove dummy file
robert-a-forsyth Sep 30, 2025
b1b384c
minor formatting
ljwharbers Oct 2, 2025
c06929a
fix in gitignore
ljwharbers Oct 2, 2025
c68827a
update snap
ljwharbers Oct 2, 2025
23185dd
add custom path
robert-a-forsyth Oct 4, 2025
4349c49
null path fix
robert-a-forsyth Oct 4, 2025
77833c3
Fix escape
robert-a-forsyth Oct 4, 2025
0656258
add index
robert-a-forsyth Oct 4, 2025
57cdfde
Fix syntax
robert-a-forsyth Oct 4, 2025
831e1f7
metaextract fix with rebasecalling
ljwharbers Oct 6, 2025
9095328
typo
ljwharbers Oct 6, 2025
233a2f5
double typo
ljwharbers Oct 6, 2025
b4729e3
add vep download args
ljwharbers Oct 6, 2025
7d35bfd
remove ext args
ljwharbers Oct 6, 2025
2a1317c
add sarek ext args
ljwharbers Oct 6, 2025
01a91bc
update snap
ljwharbers Oct 6, 2025
e891870
update wakhan
ljwharbers Oct 9, 2025
f92af47
update test ignore
ljwharbers Oct 9, 2025
f937eb6
update snap
ljwharbers Oct 9, 2025
52360a9
add centromere bed
ljwharbers Oct 10, 2025
6da0cd9
update wakhan version and fix new input
ljwharbers Oct 10, 2025
fa5112d
Merge remote-tracking branch 'origin/fiber_normals' into clairstoPON
robert-a-forsyth Oct 15, 2025
e4cf750
change normal_fiber default
robert-a-forsyth Oct 15, 2025
1aab8cf
Merge remote-tracking branch 'origin/custom_vep' into clairstoPON
robert-a-forsyth Oct 15, 2025
8d7f84a
add patch file
robert-a-forsyth Oct 15, 2025
d4032eb
fix linting
robert-a-forsyth Oct 15, 2025
b6d0e23
fix default value
robert-a-forsyth Oct 15, 2025
2a24f8c
Merge pull request #98 from IntGenomicsLab/clairstoPON
robert-a-forsyth Oct 16, 2025
4c5973f
fix clairs indel calling
robert-a-forsyth Oct 30, 2025
d60b5ee
view
robert-a-forsyth Nov 18, 2025
b20166f
fix id
robert-a-forsyth Nov 18, 2025
233059a
remove view
robert-a-forsyth Nov 18, 2025
4350f57
Revert "fix id"
robert-a-forsyth Nov 18, 2025
d3623ac
revert
robert-a-forsyth Nov 18, 2025
424befd
patch
robert-a-forsyth Nov 18, 2025
c70e403
prettier
robert-a-forsyth Nov 18, 2025
dadd850
view
robert-a-forsyth Nov 19, 2025
e459367
grouptuple fix
robert-a-forsyth Nov 19, 2025
dc30631
Template update for nf-core/tools version 3.2.0
robert-a-forsyth Nov 19, 2025
28ffe69
Template update for nf-core/tools version 3.2.0
robert-a-forsyth Nov 19, 2025
09e76f5
Template update for nf-core/tools version 3.2.0
robert-a-forsyth Nov 19, 2025
678dc48
remove nucleo arg
robert-a-forsyth Nov 19, 2025
b57b036
Template update for nf-core/tools version 3.4.1
robert-a-forsyth Nov 19, 2025
b5873ab
update template
robert-a-forsyth Nov 19, 2025
8ad5e9d
Template update for nf-core/tools version 3.5.1
robert-a-forsyth Nov 20, 2025
1780652
template update 3.5
robert-a-forsyth Nov 20, 2025
c23c967
lint fix
robert-a-forsyth Nov 20, 2025
1f610c4
update snapshot, revert test changes
robert-a-forsyth Nov 20, 2025
c64acc8
linting fix
robert-a-forsyth Nov 20, 2025
1eddb33
precommit
robert-a-forsyth Nov 20, 2025
a0b10e1
revert readme
robert-a-forsyth Nov 20, 2025
f26893d
Fix input
robert-a-forsyth Nov 20, 2025
eaf4cae
change meta.id to prefix in CLAIRS`
ljwharbers Nov 20, 2025
49d337e
indentation
ljwharbers Nov 20, 2025
484a091
remove view statement
ljwharbers Nov 20, 2025
a5a343f
add disk clean up back in
ljwharbers Nov 20, 2025
170e72b
or branch is still "main" so would keep it like it was
ljwharbers Nov 20, 2025
815f255
revert some changes
ljwharbers Nov 20, 2025
14d4b7b
revert more
ljwharbers Nov 20, 2025
ccd84a1
linting and nextflow badge
ljwharbers Nov 20, 2025
200b95f
add view
robert-a-forsyth Nov 24, 2025
550ba65
fix read-in
robert-a-forsyth Nov 24, 2025
afbb03a
fix read-in
robert-a-forsyth Nov 24, 2025
ec83c21
fix read-in
robert-a-forsyth Nov 24, 2025
339449a
fix read-in
robert-a-forsyth Nov 24, 2025
b60d5f4
Update JSON schema
robert-a-forsyth Nov 24, 2025
6bf8ee8
merge + index clairS output
robert-a-forsyth Nov 24, 2025
2c95ed2
remove view
robert-a-forsyth Nov 24, 2025
da63f26
adjust concat params
robert-a-forsyth Nov 25, 2025
67b6f9a
update test snap
robert-a-forsyth Nov 25, 2025
faf07bb
revert
robert-a-forsyth Nov 25, 2025
cffc36f
update snap
robert-a-forsyth Nov 25, 2025
29f81d0
improve file structures
robert-a-forsyth Nov 25, 2025
5a3b72b
update file descriptions
robert-a-forsyth Nov 25, 2025
6ee0718
fix file descriptions
robert-a-forsyth Nov 25, 2025
8af8469
add view
robert-a-forsyth Nov 25, 2025
9851c1f
more view
robert-a-forsyth Nov 25, 2025
160eb79
view spelling
robert-a-forsyth Nov 25, 2025
5859b29
updates to file descriptions
robert-a-forsyth Nov 25, 2025
f746e65
fix channel logic
robert-a-forsyth Nov 26, 2025
5b38eee
lint
robert-a-forsyth Nov 26, 2025
dac7854
lint
robert-a-forsyth Nov 26, 2025
87bc148
prettier
robert-a-forsyth Nov 26, 2025
7cd7898
fix channel meta
robert-a-forsyth Nov 27, 2025
8fe259c
igenomes clairsto pons
ljwharbers Nov 27, 2025
e781f03
extra touches
robert-a-forsyth Nov 27, 2025
6955466
add samtools info
robert-a-forsyth Nov 27, 2025
b638fab
remove getGenomeAttribute stuff from main.nf since we have it in lrso…
ljwharbers Nov 27, 2025
9e86276
view
robert-a-forsyth Nov 27, 2025
0d11cb9
fix multichannel
robert-a-forsyth Nov 27, 2025
4fcf630
edit view
robert-a-forsyth Nov 27, 2025
800064f
change channel
robert-a-forsyth Nov 27, 2025
e108960
Checkpoint from VS Code for coding agent session
ljwharbers Nov 27, 2025
c716e65
Add bibliography of tools used in pipeline to CITATIONS.md
Copilot Nov 27, 2025
be9e0ea
remove view
robert-a-forsyth Nov 27, 2025
144f3ee
Merge pull request #107 from IntGenomicsLab/copilot/uncomfortable-mink
ljwharbers Nov 27, 2025
0dcd704
fix citations
ljwharbers Nov 27, 2025
67f4be6
lint and snapshot
robert-a-forsyth Nov 27, 2025
5a991a6
remove todo
ljwharbers Nov 27, 2025
4b47c2f
fix lint and snap
robert-a-forsyth Nov 27, 2025
ca04e17
fix log
robert-a-forsyth Nov 27, 2025
14f6b90
removed TODOs and added citations
ljwharbers Nov 27, 2025
8881a18
whitespace
ljwharbers Nov 27, 2025
2e2f4f3
formatting
ljwharbers Nov 27, 2025
d841fd1
formatting
ljwharbers Nov 27, 2025
29ec483
add def back in
ljwharbers Nov 27, 2025
759accc
Merge pull request #99 from IntGenomicsLab/clairs_fix
robert-a-forsyth Nov 27, 2025
5b10063
Merge branch 'dev' into pr/robert-a-forsyth/103
ljwharbers Nov 27, 2025
e1d6fc7
pre-commit
ljwharbers Nov 27, 2025
d11787e
Contributions
robert-a-forsyth Nov 27, 2025
22c616b
add wakhan
robert-a-forsyth Nov 27, 2025
129acab
snap update
robert-a-forsyth Nov 28, 2025
824afdc
Merge pull request #103 from IntGenomicsLab/template
robert-a-forsyth Nov 28, 2025
5e73c3c
multi-qc + wakhan
robert-a-forsyth Nov 28, 2025
6995233
Merge branch 'dev' into documentation
robert-a-forsyth Nov 28, 2025
0fb11da
update lint
robert-a-forsyth Nov 28, 2025
2da4897
prettier
robert-a-forsyth Nov 28, 2025
bff2248
Merge pull request #106 from IntGenomicsLab/documentation
robert-a-forsyth Nov 28, 2025
7b773d0
prettier
robert-a-forsyth Nov 28, 2025
373720e
Merge pull request #105 from IntGenomicsLab/igenomes_aws
robert-a-forsyth Nov 28, 2025
74990b8
final 1.0.0 release
robert-a-forsyth Nov 28, 2025
b4e9ee0
snap
robert-a-forsyth Nov 28, 2025
592a118
fix clair stubs
robert-a-forsyth Nov 28, 2025
0c99122
prettier
robert-a-forsyth Nov 28, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"name": "nfcore",
"image": "nfcore/gitpod:latest",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],
"image": "nfcore/devcontainer:latest",

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/opt/conda/bin/python"
},
"remoteUser": "root",
"privileged": true,

// Add the IDs of extensions you want installed when the container is created.
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
}
"remoteEnv": {
// Workspace path on the host for mounting with docker-outside-of-docker
"LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}"
},

"onCreateCommand": "./.devcontainer/setup.sh",

"hostRequirements": {
"cpus": 4,
"memory": "16gb",
"storage": "32gb"
}
}
13 changes: 13 additions & 0 deletions .devcontainer/setup.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/usr/bin/env bash

# Customise the terminal command prompt
echo "export PROMPT_DIRTRIM=2" >> $HOME/.bashrc
echo "export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] '" >> $HOME/.bashrc
export PROMPT_DIRTRIM=2
export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] '

# Update Nextflow
nextflow self-update

# Update welcome message
echo "Welcome to the IntGenomicsLab/lrsomatic devcontainer!" > /usr/local/etc/vscode-dev-containers/first-run-notice.txt
37 changes: 0 additions & 37 deletions .editorconfig

This file was deleted.

18 changes: 9 additions & 9 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
# `IntGenomicsLab/lr_somatic`: Contributing Guidelines
# `IntGenomicsLab/lrsomatic`: Contributing Guidelines

Hi there!
Many thanks for taking an interest in improving IntGenomicsLab/lr_somatic.
Many thanks for taking an interest in improving IntGenomicsLab/lrsomatic.

We try to manage the required tasks for IntGenomicsLab/lr_somatic using GitHub issues, you probably came to this page when creating one.
We try to manage the required tasks for IntGenomicsLab/lrsomatic using GitHub issues, you probably came to this page when creating one.
Please use the pre-filled template to save time.

However, don't be put off by this template - other more general issues and suggestions are welcome!
Contributions to the code are even more welcome ;)

## Contribution workflow

If you'd like to write some code for IntGenomicsLab/lr_somatic, the standard workflow is as follows:
If you'd like to write some code for IntGenomicsLab/lrsomatic, the standard workflow is as follows:

1. Check that there isn't already an issue about your idea in the [IntGenomicsLab/lr_somatic issues](https://github.com/IntGenomicsLab/lr_somatic/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [IntGenomicsLab/lr_somatic repository](https://github.com/IntGenomicsLab/lr_somatic) to your GitHub account
1. Check that there isn't already an issue about your idea in the [IntGenomicsLab/lrsomatic issues](https://github.com/IntGenomicsLab/lrsomatic/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [IntGenomicsLab/lrsomatic repository](https://github.com/IntGenomicsLab/lrsomatic) to your GitHub account
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
4. Use `nf-core pipelines schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged
Expand Down Expand Up @@ -58,7 +58,7 @@ These tests are run both with the latest available version of `Nextflow` and als

## Pipeline contribution conventions

To make the `IntGenomicsLab/lr_somatic` code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.
To make the `IntGenomicsLab/lrsomatic` code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.

### Adding a new step

Expand All @@ -71,7 +71,7 @@ If you wish to contribute a new step, please use the following coding standards:
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core pipelines schema build` tool).
6. Add sanity checks and validation for all relevant parameters.
7. Perform local tests to validate that the new code works as expected.
8. If applicable, add a new test command in `.github/workflow/ci.yml`.
8. If applicable, add a new test in the `tests` directory.
9. Update MultiQC config `assets/multiqc_config.yml` so relevant suffixes, file name clean up and module plots are in the appropriate order. If applicable, add a [MultiQC](https://https://multiqc.info/) module.
10. Add a description of the output files and if relevant any appropriate images from the MultiQC report to `docs/output.md`.

Expand Down Expand Up @@ -108,7 +108,7 @@ This repo includes a devcontainer configuration which will create a GitHub Codes

To get started:

- Open the repo in [Codespaces](https://github.com/IntGenomicsLab/lr_somatic/codespaces)
- Open the repo in [Codespaces](https://github.com/IntGenomicsLab/lrsomatic/codespaces)
- Tools installed
- nf-core
- Nextflow
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ body:
* Executor _(eg. slurm, local, awsbatch)_
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter, Charliecloud, or Apptainer)_
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
* Version of IntGenomicsLab/lr_somatic _(eg. 1.1, 1.5, 1.8.2)_
* Version of IntGenomicsLab/lrsomatic _(eg. 1.1, 1.5, 1.8.2)_
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Feature request
description: Suggest an idea for the IntGenomicsLab/lr_somatic pipeline
description: Suggest an idea for the IntGenomicsLab/lrsomatic pipeline
labels: enhancement
body:
- type: textarea
Expand Down
8 changes: 4 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
<!--
# IntGenomicsLab/lr_somatic pull request
# IntGenomicsLab/lrsomatic pull request

Many thanks for contributing to IntGenomicsLab/lr_somatic!
Many thanks for contributing to IntGenomicsLab/lrsomatic!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release.

Learn more about contributing: [CONTRIBUTING.md](https://github.com/IntGenomicsLab/lr_somatic/tree/main/.github/CONTRIBUTING.md)
Learn more about contributing: [CONTRIBUTING.md](https://github.com/IntGenomicsLab/lrsomatic/tree/main/.github/CONTRIBUTING.md)
-->

## PR checklist

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/IntGenomicsLab/lr_somatic/tree/main/.github/CONTRIBUTING.md)
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/IntGenomicsLab/lrsomatic/tree/main/.github/CONTRIBUTING.md)
- [ ] Make sure your code lints (`nf-core pipelines lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
Expand Down
69 changes: 69 additions & 0 deletions .github/actions/get-shards/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
name: "Get number of shards"
description: "Get the number of nf-test shards for the current CI job"
inputs:
max_shards:
description: "Maximum number of shards allowed"
required: true
paths:
description: "Component paths to test"
required: false
tags:
description: "Tags to pass as argument for nf-test --tag parameter"
required: false
outputs:
shard:
description: "Array of shard numbers"
value: ${{ steps.shards.outputs.shard }}
total_shards:
description: "Total number of shards"
value: ${{ steps.shards.outputs.total_shards }}
runs:
using: "composite"
steps:
- name: Install nf-test
uses: nf-core/setup-nf-test@v1
with:
version: ${{ env.NFT_VER }}
- name: Get number of shards
id: shards
shell: bash
run: |
# Run nf-test with dynamic parameter
nftest_output=$(nf-test test \
--profile +docker \
$(if [ -n "${{ inputs.tags }}" ]; then echo "--tag ${{ inputs.tags }}"; fi) \
--dry-run \
--ci \
--changed-since HEAD^) || {
echo "nf-test command failed with exit code $?"
echo "Full output: $nftest_output"
exit 1
}
echo "nf-test dry-run output: $nftest_output"
# Default values for shard and total_shards
shard="[]"
total_shards=0
# Check if there are related tests
if echo "$nftest_output" | grep -q 'No tests to execute'; then
echo "No related tests found."
else
# Extract the number of related tests
number_of_shards=$(echo "$nftest_output" | sed -n 's|.*Executed \([0-9]*\) tests.*|\1|p')
if [[ -n "$number_of_shards" && "$number_of_shards" -gt 0 ]]; then
shards_to_run=$(( $number_of_shards < ${{ inputs.max_shards }} ? $number_of_shards : ${{ inputs.max_shards }} ))
shard=$(seq 1 "$shards_to_run" | jq -R . | jq -c -s .)
total_shards="$shards_to_run"
else
echo "Unexpected output format. Falling back to default values."
fi
fi
# Write to GitHub Actions outputs
echo "shard=$shard" >> $GITHUB_OUTPUT
echo "total_shards=$total_shards" >> $GITHUB_OUTPUT
# Debugging output
echo "Final shard array: $shard"
echo "Total number of shards: $total_shards"
111 changes: 111 additions & 0 deletions .github/actions/nf-test/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
name: "nf-test Action"
description: "Runs nf-test with common setup steps"
inputs:
profile:
description: "Profile to use"
required: true
shard:
description: "Shard number for this CI job"
required: true
total_shards:
description: "Total number of test shards(NOT the total number of matrix jobs)"
required: true
paths:
description: "Test paths"
required: true
tags:
description: "Tags to pass as argument for nf-test --tag parameter"
required: false
runs:
using: "composite"
steps:
- name: Setup Nextflow
uses: nf-core/setup-nextflow@v2
with:
version: "${{ env.NXF_VERSION }}"

- name: Set up Python
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
with:
python-version: "3.14"

- name: Install nf-test
uses: nf-core/setup-nf-test@v1
with:
version: "${{ env.NFT_VER }}"
install-pdiff: true

- name: Setup apptainer
if: contains(inputs.profile, 'singularity')
uses: eWaterCycle/setup-apptainer@main

- name: Set up Singularity
if: contains(inputs.profile, 'singularity')
shell: bash
run: |
mkdir -p $NXF_SINGULARITY_CACHEDIR
mkdir -p $NXF_SINGULARITY_LIBRARYDIR

- name: Conda setup
if: contains(inputs.profile, 'conda')
uses: conda-incubator/setup-miniconda@505e6394dae86d6a5c7fbb6e3fb8938e3e863830 # v3
with:
auto-update-conda: true
conda-solver: libmamba
channels: conda-forge
channel-priority: strict
conda-remove-defaults: true

- name: Run nf-test
shell: bash
env:
NFT_WORKDIR: ${{ env.NFT_WORKDIR }}
run: |
nf-test test \
--profile=+${{ inputs.profile }} \
$(if [ -n "${{ inputs.tags }}" ]; then echo "--tag ${{ inputs.tags }}"; fi) \
--ci \
--changed-since HEAD^ \
--verbose \
--tap=test.tap \
--shard ${{ inputs.shard }}/${{ inputs.total_shards }}

# Save the absolute path of the test.tap file to the output
echo "tap_file_path=$(realpath test.tap)" >> $GITHUB_OUTPUT

- name: Generate test summary
if: always()
shell: bash
run: |
# Add header if it doesn't exist (using a token file to track this)
if [ ! -f ".summary_header" ]; then
echo "# 🚀 nf-test results" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "| Status | Test Name | Profile | Shard |" >> $GITHUB_STEP_SUMMARY
echo "|:------:|-----------|---------|-------|" >> $GITHUB_STEP_SUMMARY
touch .summary_header
fi

if [ -f test.tap ]; then
while IFS= read -r line; do
if [[ $line =~ ^ok ]]; then
test_name="${line#ok }"
# Remove the test number from the beginning
test_name="${test_name#* }"
echo "| ✅ | ${test_name} | ${{ inputs.profile }} | ${{ inputs.shard }}/${{ inputs.total_shards }} |" >> $GITHUB_STEP_SUMMARY
elif [[ $line =~ ^not\ ok ]]; then
test_name="${line#not ok }"
# Remove the test number from the beginning
test_name="${test_name#* }"
echo "| ❌ | ${test_name} | ${{ inputs.profile }} | ${{ inputs.shard }}/${{ inputs.total_shards }} |" >> $GITHUB_STEP_SUMMARY
fi
done < test.tap
else
echo "| ⚠️ | No test results found | ${{ inputs.profile }} | ${{ inputs.shard }}/${{ inputs.total_shards }} |" >> $GITHUB_STEP_SUMMARY
fi

- name: Clean up
if: always()
shell: bash
run: |
sudo rm -rf /home/ubuntu/tests/
4 changes: 2 additions & 2 deletions .github/workflows/branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
steps:
# PRs to the nf-core repo main/master branch are only ok if coming from the nf-core repo `dev` or any `patch` branches
- name: Check PRs
if: github.repository == 'IntGenomicsLab/lr_somatic'
if: github.repository == 'IntGenomicsLab/lrsomatic'
run: |
{ [[ ${{github.event.pull_request.head.repo.full_name }} == IntGenomicsLab/lr_somatic ]] && [[ $GITHUB_HEAD_REF == "dev" ]]; } || [[ $GITHUB_HEAD_REF == "patch" ]]
{ [[ ${{github.event.pull_request.head.repo.full_name }} == IntGenomicsLab/lrsomatic ]] && [[ $GITHUB_HEAD_REF == "dev" ]]; } || [[ $GITHUB_HEAD_REF == "patch" ]]

# If the above check failed, post a comment on the PR explaining the failure
# NOTE - this doesn't currently work if the PR is coming from a fork, due to limitations in GitHub actions secrets
Expand Down
Loading
Loading