Conversation
Collaborator
Author
|
|
Collaborator
Author
|
There is a GitHub actions workflow for mdBook and GitHub pages https://github.com/Insprill/dv-mapify/actions/new?category=none&query=mdbook |
Collaborator
Author
|
i got it to work with GitHub Pages: https://t0stiman.github.io/dv-mapify/ |
Insprill
requested changes
Aug 15, 2025
.gitignore
Outdated
| !PackageBuilder/Assets/Mapify.meta | ||
| PackageBuilder/Assets/Mapify/Scripts/* | ||
| !PackageBuilder/Assets/Mapify/Scripts/*meta | ||
| PackageBuilder/Assets/Mapify/Scripts/*.dll |
Owner
There was a problem hiding this comment.
Why were some of these moved to a dedicated .gitignore and some aren't? These changes should be moved to a separate PR so it doesn't block this.
Collaborator
Author
There was a problem hiding this comment.
The idea was to have PackageBuilder/.gitignore be a pure, unchanged Unity gitignore file and specify our own additions in the main gitignore.
Collaborator
Author
There was a problem hiding this comment.
I can move the lines concerning PackageBuilder into PackageBuilder/.gitignore if you want?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw your comment about switching to mdBook, and I thought why not give it a go. I updated the documentation for building the documentation as well.
For hosting the generated html files, i suggest github pages because it's free and easy.