Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Address non-const operations when TBB enabled in test #5098

Merged
merged 1 commit into from
Dec 19, 2024
Merged

COMP: Address non-const operations when TBB enabled in test #5098

merged 1 commit into from
Dec 19, 2024

Conversation

blowekamp
Copy link
Member

Addresses the following build error:
https://open.cdash.org/viewBuildError.php?buildid=10099800

Do we not a TBB build in CI?

@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module labels Dec 19, 2024
@dzenanz
Copy link
Member

dzenanz commented Dec 19, 2024

I guess we need to add -DModule_ITKTBB:BOOL=ON here, or somewhere else in that file.

hjmjohnson
hjmjohnson approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS BRAD! I was on my todo today after I give my final exam. I appreciate you addressing this more quickly.

@blowekamp blowekamp force-pushed the fix_const_theader_test branch from cd7b5b3 to 2dd2a65 Compare December 19, 2024 18:15
@blowekamp blowekamp marked this pull request as ready for review December 19, 2024 23:39
@blowekamp blowekamp merged commit f0eadd9 into InsightSoftwareConsortium:master Dec 19, 2024
15 checks passed
@dzenanz
Copy link
Member

dzenanz commented Jan 13, 2025

I added some MacOS nightly builds recently. The one called MacOS-Rel-Favorite-Remotes already has TBB enabled, and I just also added it to MacOS-Rel-Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blowekamp @dzenanz @hjmjohnson