Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update CMake minimum support to 3.22.1 #5097

Merged

Conversation

blowekamp
Copy link
Member

The update to HDF5 #4940, added a required CMake minimum version of 3.18. Update the top-level requirement to match.

While possible to build ITK without HDF5, this is not a common configuration. The non-minimum requirement at the top level can be considered a bug.

Note: Ubuntu 20.04 contains cmake 2.16.3, but standard support end April 2025 ( likely before the ITK 6.0 final release).

@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation labels Dec 19, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
@@ -10,7 +10,7 @@
# CMake versions greater than the ITK_NEWEST_VALIDATED_POLICIES_VERSION policies will
# continue to generate policy warnings "CMake Warning (dev)...Policy CMP0XXX is not set:"
#
set(ITK_OLDEST_VALIDATED_POLICIES_VERSION "3.16.3")
set(ITK_OLDEST_VALIDATED_POLICIES_VERSION "3.18.0")
set(ITK_NEWEST_VALIDATED_POLICIES_VERSION "3.29.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: homebrew mac version of 3.31.2 seems to work fine too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the highest verified version in a separate PR. That update needs some testing.

@blowekamp blowekamp force-pushed the update_cmake_version branch from 86b9d18 to 3c4ed38 Compare December 23, 2024 20:53
@dzenanz dzenanz changed the title ENH: Update CMake minimum support to 3.18.0 ENH: Update CMake minimum support to 3.22.1 Dec 26, 2024
@blowekamp blowekamp marked this pull request as ready for review January 2, 2025 13:15
@blowekamp blowekamp requested a review from hjmjohnson January 2, 2025 13:15
@dzenanz dzenanz merged commit 2fd36ab into InsightSoftwareConsortium:master Jan 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants