Add constexpr to compile time const variables #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
added
the
type:Style
github-actions
bot
removed
the
type:Style
hjmjohnson
force-pushed
the
add-constexpr
branch
from
a332ae8 to
507b2b3
Compare
|
@hjmjohnson Great work on these style improvements 😍 As I was working on the VectorImage bug, I was looking at the NumericTraits classes. You may want to look at these classes and see if methods like SetLength and others could be made constexpr. I think there are large potential for performance improvements using "if constexpr" statements in tight filter loops. I am sure your queue is filled with items, but just wanted to mention this for your consideration. |
dzenanz
approved these changes
Dec 17, 2024
dzenanz
approved these changes
Dec 17, 2024
Implements detection of local variables which could be declared as const but
are not. Declaring variables as const is recommended by many coding
guidelines, such as: ES.25 from the C++ Core Guidelines.
cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,misc-const-correctness -header-filter=.* -fix
IDE can identify these cases, but code changes are implemented manually
REPLACE: (^ *)const *([a-zA-Z0-9_:]* [0-9a-zA-Z_]* = *[\+\-e0-9\.]+;)
WITH: $1constexpr $2
REPLACE: (^ *)const (\w* \w*\{\}\;)
WITH: $1constexpr $2
If statement with compile-time constant can be replaced with "if constexpr"
The test for epsilon > 0 is always true because epsilon is a constexpr greater than 0.
[CTest: warning matched] /Users/builder/externalModules/Filtering/ImageCompare/test/itkSimilarityIndexImageFilterTest.cxx:63:18:
warning: result of comparison of 0 <= unsigned expression is always true [-Wtautological-unsigned-zero-compare]
63 | if (lower1 <= count && count <= upper1)
| ~~~~~~ ^ ~~~~~
[CTest: warning suppressed] 1 warning generated.
Windows build failed when making an unused variable constexpr. Modules\Core\Common\test\itkVectorContainerTest.cxx(54): error C2127: 'p_null': illegal initialization of 'constexpr' entity with a non-constant expression Remove the unused variable to avoid the problem.
hjmjohnson
force-pushed
the
add-constexpr
branch
from
a1ab02c to
bf64637
Compare
hjmjohnson
merged commit 74916a5
into
InsightSoftwareConsortium:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDE can identify these cases, but code changes are implemented manually
If statement with compile-time constant can be replaced with "if constexpr"
PR Checklist