Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove top-level const from return types in "Bridge/NumPy", and other style commits #4878

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Remove top-level const from return types in "Bridge/NumPy", and other style commits #4878

merged 5 commits into from
Oct 17, 2024

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker
STYLE: Remove top-level const from return types in "Bridge/NumPy"
fb19b14 
Removing these `const` keywords enables move semantics, which may improve the
performance.

Follow-up to pull request InsightSoftwareConsortium#4872
commit 8a1498c
"STYLE: Remove `const` from `const std::string` return types"
@N-Dekker
STYLE: Remove local obj (= shape) variables from "Bridge/NumPy"
85b6dd8 
These `obj` variables always pointed to the same object as the corresponding
`shape` parameter. Declared `shape` "const", just to be sure.
@N-Dekker
STYLE: Reduce scope of local item variables in "Bridge/NumPy"
b1def9f 
Following C++ Core Guidelines, Oct 3, 2024, "Keep scopes small",
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es5-keep-scopes-small
@N-Dekker
STYLE: Remove unnecessary local output variables from PyVnl
be745e2 
Let `_GetVnlVectorFromArray` and `_GetVnlMatrixFromArray` directly return the
constructed object. It is unnecessary to first store it in a local variable.
@N-Dekker
STYLE: Remove local memoryView variables from "Bridge/NumPy"
3cdddf7 
Directly return `PyMemoryView_FromBuffer(&pyBuffer)` instead.
@github-actions github-actions bot added the area:Bridge Issues affecting the Bridge module label Oct 10, 2024
@N-Dekker N-Dekker marked this pull request as ready for review October 10, 2024 11:59
@dzenanz dzenanz merged commit a434e3f into InsightSoftwareConsortium:master Oct 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:Bridge Issues affecting the Bridge module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N-Dekker @dzenanz