COMP: Specify GeometricalQuadEdge in PointSetBase wrapping QuadEdgeMesh #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aims to address Windows specific wrapping failures at the CI (https://open.cdash.org/viewBuildError.php?type=1&buildid=9948358), including: itkQuadEdgeMeshBase: warning(4): ITK type not wrapped, or currently not known: itk::QuadEdgeMeshPoint< float, 2 > And locally, from Visual Studio 2022: Bin\ITK\Wrapping\Typedefs\itkQuadEdgeMeshBase.i(1220): warning 401: Nothing known about base class 'itk::PointSetBase< itk::MapContainer< unsigned long long,itk::QuadEdgeMeshPoint< float,2,itk::GeometricalQuadEdge< unsigned long long,unsigned long long,bool,bool > > > >'. Ignored. Bin\ITK\Wrapping\Typedefs\itkQuadEdgeMeshBase.i(1220): warning 401: Maybe you forgot to instantiate 'itk::PointSetBase< itk::MapContainer< unsigned long long,itk::QuadEdgeMeshPoint< float,2,itk::GeometricalQuadEdge< unsigned long long,unsigned long long,bool,bool > > > >' using %template. As mentioned at InsightSoftwareConsortium#4867 (comment)
github-actions
bot
added
type:Compiler
dzenanz
approved these changes
Oct 9, 2024
|
Mark it ready for review so we can merge it? |
|
It does fix the errors that I had locally, using Visual Studio 2022. So I have good hope that it will also make the CI (specifically ITK.Windows.Python) happy. |
|
🎉 It did it! Commit 50cc93a successfully passed at https://github.com/InsightSoftwareConsortium/ITK/commits/master/, including "ITK.Windows.Python"! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address Windows specific wrapping failures at the CI (https://open.cdash.org/viewBuildError.php?type=1&buildid=9948358), including:
And locally, from Visual Studio 2022:
As mentioned at #4867 (comment)