COMP: missing include in itkMetaDataObjectDetail.h

[pzaffino]

Missing include in tkMetaDataObjectDetail.h.
On my system (Arch Linux, GCC 14.2.1, cmake 3.30.5) it didn't compile without this edit.

[github-actions]

Thank you for contributing a pull request! 🙏

Welcome to the ITK community! 🤗👋☀️

We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖

This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.

[N-Dekker]

@pzaffino Thank you for your fix, Pablo 👍

It appears that the CI complains about the commit message. It should be more like:

COMP: Add missing include in itkMetaDataObjectDetail.h

Specifically, the CI wants to have one of those prefixes: BUG, COMP, DOC, ENH, PERF, or STYLE. I think "COMP" is most appropriate in this case, as you are addressing a compilation problem.

Can you please amend you commit, and then do git review-push --force?

[N-Dekker]

Instead of <ostream>, would <iosfwd> also work for you? You know, <iosfwd> is more lightweight, as it only forward-declares std::ostream.

[pzaffino]

@N-Dekker it works also with iosfwd.
The second commit is done.

[dzenanz]

Let's squash and rewrite the commit message upon merge.

[N-Dekker]

@pzaffino Thank you very much! Is it OK to you if I squash the two commits together and adjust the commit message?

[pzaffino]

Sure! Il gio 10 ott 2024, 08:40 Niels Dekker ***@***.***> ha scritto:

…

@pzaffino <https://github.com/pzaffino> Thank you very much! Is it OK to you if I squash the two commits together and adjust the commit message? — Reply to this email directly, view it on GitHub <#4874 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAP27RDXGZVU5HKSBFRBA3Z2YONVAVCNFSM6AAAAABPUHKI5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBUGE3TENRZG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- ---------------------------------------------------------------------------------------------------------------------------------------------------------- *PRIVACY:* *In ottemperanza con il nuovo Regolamento Europeo GDPR n. 679/2016, le informazioni contenute in questo messaggio sono riservate e il loro utilizzo è consentito esclusivamente al destinatario del messaggio. Qualora Lei non fosse la persona a cui il presente messaggio è destinato, La invitiamo a non leggere, copiare, inoltrare o salvare sul suo computer; qualora Lei avesse ricevuto il presente messaggio per errore ne dia immediata comunicazione con una e-mail al mittente e cancelli il messaggio.  * *L’Amministrazione opera in conformità al nuovo Regolamento Europeo GDPR n. 679/2016. Per qualsiasi informazione a riguardo si prega di contattare l’indirizzo ***@***.*** ***@***.***>* *PRIVACY:** In accordance with the European Data Protecion Regulation (2016/679), the information contained in this e mail message is strictly confidential and intended for the use of the addressee only. If you are not the intended recipient, please do not read, copy, forward or store it on your computer; If you have received this message in error, please advise the sender immediately by e-mail and delete this message. * *The Administration operates in accordance with the European GDPR Regulation. For any information, please contact the e-mail address: ***@***.*** ***@***.***>.***

[N-Dekker]

In general I'm reluctant to adjust someone else's commits (like GitHub's Squash and Merge does). But in this case, well, it's just one line of code and it has high priority, in my opinion, so I just did it 😃