Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Get ITK_USE_FLOAT_SPACE_PRECISION=ON to compile again #4811

Merged
merged 2 commits into from
Aug 21, 2024
Merged

COMP: Get ITK_USE_FLOAT_SPACE_PRECISION=ON to compile again #4811

merged 2 commits into from
Aug 21, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Aug 20, 2024

No description provided.

@thewtex thewtex requested a review from dzenanz August 20, 2024 16:06
@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Examples Demonstration of the use of classes type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module labels Aug 20, 2024
@dzenanz
Copy link
Member

dzenanz commented Aug 20, 2024

This runs into the same issue as #4805.

@thewtex
COMP: Remove unused setuptools upgrade in Linux builds
2734a97 
Avoid unrelated `importlib_metadata` errors reported in InsightSoftwareConsortium#4781
@github-actions github-actions bot added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Aug 20, 2024
@thewtex
Copy link
Member Author

thewtex commented Aug 20, 2024

This runs into the same issue as #4805.

I cherry-picked the requisite patch.

@dzenanz
Copy link
Member

dzenanz commented Aug 21, 2024

/azp run ITK.macOS.Python

@dzenanz dzenanz mentioned this pull request Aug 21, 2024
Closed
2 tasks
@dzenanz dzenanz mentioned this pull request Aug 21, 2024
Merged
@dzenanz dzenanz merged commit e78f1c9 into InsightSoftwareConsortium:release-5.4 Aug 21, 2024
13 checks passed
@dzenanz dzenanz mentioned this pull request Aug 21, 2024
Closed
2 tasks
@dzenanz
Copy link
Member

dzenanz commented Aug 21, 2024

After merging here, I manually merged this to release and master.

@dzenanz dzenanz mentioned this pull request Aug 21, 2024
Merged
@thewtex thewtex deleted the space-precision-for-release-5.4 branch August 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@seanm seanm seanm approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Examples Demonstration of the use of classes area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewtex @dzenanz @seanm