-Wextra-semi

[andrei-sandor]

This is part 2 of if the following changes regarding the -Wextra-semi (semi = semicolon) warning of clang can be done throughout the repository. #4679

COMP: Remove ; from itkBooleanMacro

COMP: Remove ; from other itk macros

COMP: Updated itkLegacyMacro Definition. We decided to change the definition of itkLegacyMacro to not have two ; if the if defined(ITK_LEGACY_REMOVE) branch is hit.

COMP: Remove ITK_ASSOCIATE ; or struct;
Should we remove the semicolon from the struct or from ITK_ASSOCIATE?

COMP: Remove ; to function cases

COMP: Remove cases with ; to override cases

COMP: Remove ; IPL cases

[seanm]

clang-format screwed this up, you need to add this macro to that list in the .clang-format file to get it to format correctly.

[seanm]

Formatting wrong here too. Hopefully running clang-format will fix it, since you added these macros to StatementMacros.

[hjmjohnson]

I would really prefer to NOT remove the semi-colons. It makes clang-formatting very challenging and tedious. Additionally, many modern IDE's complain about the lack of ; at the end of what is interpreted as a statement.

I would prefer that the macros are always terminated by a statement, or a NOOP statement as is proposed in #4706

[seanm]

It makes clang-formatting very challenging and tedious.

How so? Are you perhaps not aware of clang-format's statementmacros setting?

Additionally, many modern IDE's complain about the lack of ; at the end of what is interpreted as a statement.

I've never seen that, could you give an example?

[hjmjohnson]

Look at the ITK_MACRO_NOOP mechanism.

We want the ; colon here to keep the code consistent. It may be that the we need to update the itkMacro.h to get rid of these.

[hjmjohnson]

NOTE: ALSO ENSURE THAT "ITK_LEGACY_REMOVE" and ITK_FUTURE_LEGACY_REMOVE is turned on when running this flag for testing.

[seanm]

We want the ; colon here to keep the code consistent.

You want the semi colon there? Even though you wouldn't if the macro's equivalent was written out by hand?

Example, itkBooleanMacro(ThreaderUpdateProgress) written manually would be:

  virtual void ThreaderUpdateProgressOn() { this->SetThreaderUpdateProgress(true); }
  virtual void ThreaderUpdateProgressOff() { this->SetThreaderUpdateProgress(false); }

which you wouldn't generally write as:

  virtual void ThreaderUpdateProgressOn() { this->SetThreaderUpdateProgress(true); }
  virtual void ThreaderUpdateProgressOff() { this->SetThreaderUpdateProgress(false); };

As this macro isn't a function-like (or statement-like) macro, it seems odd to end it with a semi.

[hjmjohnson]

I would really prefer to NOT remove the semi-colons. It makes clang-formatting very challenging and tedious. Additionally, many modern IDE's complain about the lack of ; at the end of what is interpreted as a statement.

I would prefer that the macros are always terminated by a statement, or a NOOP statement as is proposed in #4706

[hjmjohnson]

Closing. I think this work is superceeded with updates made in the master branch that elminiates the need to remove the ";" from macros.

[seanm]

Some of the commits here are still good, but we'll make a new PR.