Skip to content

don't always check syncable attributes #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

don't always check syncable attributes #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/salesforce_ar_sync/salesforce_sync.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,15 @@ def salesforce_should_update_attribute?(attribute)
def salesforce_attributes_to_update(include_all = false)
{}.tap do |hash|
self.class.salesforce_sync_attribute_mapping.each do |key, value|
next unless respond_to?(value)
next if !respond_to?(value) ||
self.class.readonly_fields&.include?(key.to_sym) ||
(!include_all && !salesforce_should_update_attribute?(value))

# Checkboxes in SFDC Cannot be nil. Here we check for boolean field type and set nil values to be false
attribute_value = send(value)
attribute_value = false if is_boolean?(value) && attribute_value.nil?

hash[key] = attribute_value if !self.class.readonly_fields&.include?(key.to_sym) && (include_all || salesforce_should_update_attribute?(value))
hash[key] = attribute_value
end
end
end
Expand Down