Skip to content

feat: reactor netty ssl - #297

Closed
NguyenHoangSon96 wants to merge 1 commit into
mainfrom
example/reactor-netty-ssl
Closed

NguyenHoangSon96 wants to merge 1 commit into
mainfrom
example/reactor-netty-ssl

Conversation

@NguyenHoangSon96

@NguyenHoangSon96 NguyenHoangSon96 commented Oct 27, 2025 •

Copy link
Copy Markdown
Contributor

Closes #

Proposed Changes

  • I deleted my previous descriptions, so I will write them again.

Reason to choose reactor-netty

  • Netty alone is just too low-level HTTP library, so I use reactor-netty.

Reasons to pass "io.netty.handler.ssl.SslContext" instead of Nett Http Client

  • Arrow Flight does not support passing Netty Http Client directly to their lib.
  • Both netty-reactor and Arrow Flight gRPC support passing pre-configured "io.netty.handler.ssl.SslContext". So users just need to configure the "io.netty.handler.ssl.SslContext" one time and use it in two places.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Oct 27, 2025
@NguyenHoangSon96
NguyenHoangSon96 marked this pull request as ready for review October 29, 2025 09:49
@NguyenHoangSon96
NguyenHoangSon96 requested review from bednar and removed request for bednar November 3, 2025 11:49

@bednar bednar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide list of new dependencies which the reactor bom brings to the project.

@NguyenHoangSon96
NguyenHoangSon96 marked this pull request as draft November 18, 2025 05:37
@NguyenHoangSon96

Copy link
Copy Markdown
Contributor Author

Should not use netty-reactor. Will close this issue

@NguyenHoangSon96
NguyenHoangSon96 deleted the example/reactor-netty-ssl branch November 21, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants