Skip to content

feat: add comment for getMeasurement function - #251

Merged
NguyenHoangSon96 merged 3 commits into
mainfrom
feat/add-comment-for-measurement
Jul 24, 2025
Merged

feat: add comment for getMeasurement function#251
NguyenHoangSon96 merged 3 commits into
mainfrom
feat/add-comment-for-measurement

Conversation

@NguyenHoangSon96

@NguyenHoangSon96 NguyenHoangSon96 commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Add comments to warn user that getMeasurement() function will return null when querying with SQL Query.
  • Reference Link.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Jul 23, 2025
@NguyenHoangSon96 NguyenHoangSon96 added this to the 1.3.0 milestone Jul 23, 2025
@codecov

codecov Bot commented Jul 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (dd371d8) to head (0091fb0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          20       20           
  Lines        1207     1207           
  Branches      188      188           
=======================================
  Hits         1088     1088           
  Misses         42       42           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96
NguyenHoangSon96 merged commit 986a398 into main Jul 24, 2025
2 checks passed
@NguyenHoangSon96
NguyenHoangSon96 deleted the feat/add-comment-for-measurement branch July 24, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants