-
Notifications
You must be signed in to change notification settings - Fork 6
Google code format #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
580529b
Add google java format docker compose and update README about it
fangpenlin 30da363
Format code
fangpenlin eb1e05a
Update readme
fangpenlin e325922
Fix broken ci by bumping ch.qos.logback ver
fangpenlin b5335df
style for compose yaml file
fangpenlin 4479367
Update readme and rename docker compose file
fangpenlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,4 +37,13 @@ Please do not file GitHub issues or post on our public forum for security vulner | |
|
|
||
| Infisical takes security issues very seriously. If you have any concerns about Infisical or believe you have uncovered a vulnerability, please get in touch via the e-mail address [email protected]. In the message, try to provide a description of the issue and ideally a way of reproducing it. The security team will get back to you as soon as possible. | ||
|
|
||
| Note that this security address should be used only for undisclosed vulnerabilities. Please report any security problems to us before disclosing it publicly. | ||
| Note that this security address should be used only for undisclosed vulnerabilities. Please report any security problems to us before disclosing it publicly. | ||
|
|
||
| ## Code style | ||
|
|
||
| The non-generated Java code in this project should be formatted with [google-java-format](https://github.com/google/google-java-format). | ||
| To run it for all the Java files in the project, use the following command: | ||
|
|
||
| ```bash | ||
| docker-compose run format | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| version: '3.8' | ||
|
|
||
| services: | ||
| format: | ||
| image: cimg/openjdk:21.0 | ||
| volumes: | ||
| - .:/app | ||
| working_dir: /app | ||
| environment: | ||
| - GOOGLE_JAVA_FORMAT_VERSION=1.30.0 | ||
| command: > | ||
| bash -c ' | ||
| curl -sSL https://github.com/google/google-java-format/releases/download/v${GOOGLE_JAVA_FORMAT_VERSION}/google-java-format-${GOOGLE_JAVA_FORMAT_VERSION}-all-deps.jar -o /tmp/google-java-format.jar && | ||
| java -jar /tmp/google-java-format.jar --replace $(find . -type f -name "*.java") | ||
| ' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,7 +82,7 @@ | |
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-core</artifactId> | ||
| <version>1.5.13</version> | ||
| <version>1.5.19</version> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just mentioning, #12. Updating logback classic and core will resolve this issue too. |
||
| </dependency> | ||
|
|
||
| <dependency> | ||
|
|
@@ -95,7 +95,7 @@ | |
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.5.6</version> | ||
| <version>1.5.19</version> | ||
| </dependency> | ||
|
|
||
| <!-- HTTP request dependencies--> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.