Skip to content

Fix punctuation in master password documentation - #357

Merged
saifsmailbox98 merged 1 commit into
mainfrom
saifsmailbox98-patch-1
Jul 31, 2026
Merged

Fix punctuation in master password documentation#357
saifsmailbox98 merged 1 commit into
mainfrom
saifsmailbox98-patch-1

Conversation

@saifsmailbox98

Copy link
Copy Markdown
Collaborator

Corrected punctuation in master password section.

Summary

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation
  • CI / build

Test plan

  • Existing tests pass (make test)
  • Added/updated tests for new behavior
  • Manual testing (describe below)

Security checklist

  • No secrets or credentials in code
  • No new unauthenticated endpoints
  • Input validation on new API surfaces
  • Checked for OWASP top 10 (injection, XSS, etc.)

Corrected punctuation in master password section.
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-agent-vault-357-fix-punctuation-in-master-password-documentation

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR changes the punctuation separating the database warning from the instruction to stop all instances.

Confidence Score: 4/5

The PR is safe to merge, though the edited sentence should use an em dash, semicolon, or period instead of a single hyphen.

The documentation-only change has no runtime or security impact, but it does not correctly resolve the punctuation issue it targets.

Files Needing Attention: docs/reference/cli.mdx

Important Files Changed

Filename Overview
docs/reference/cli.mdx Replaces a double hyphen with a single hyphen, but the resulting clause separator is still grammatically incorrect.

Reviews (1): Last reviewed commit: "Fix punctuation in master password docum..." | Re-trigger Greptile

Comment thread docs/reference/cli.mdx
## Master password

Manage the master password that wraps the data encryption key (DEK). All commands require the server to be stopped. When `DATABASE_URL` is set, these commands require `--force` because multiple instances may share the database -- stop all instances first.
Manage the master password that wraps the data encryption key (DEK). All commands require the server to be stopped. When `DATABASE_URL` is set, these commands require `--force` because multiple instances may share the database - stop all instances first.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Single hyphen separates clauses

The changed sentence uses a single hyphen to separate two independent clauses, so the punctuation correction remains grammatically incorrect and makes the instruction less clear.

Suggested change
Manage the master password that wraps the data encryption key (DEK). All commands require the server to be stopped. When `DATABASE_URL` is set, these commands require `--force` because multiple instances may share the database - stop all instances first.
Manage the master password that wraps the data encryption key (DEK). All commands require the server to be stopped. When `DATABASE_URL` is set, these commands require `--force` because multiple instances may share the database stop all instances first.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@saifsmailbox98
saifsmailbox98 merged commit 795e19a into main Jul 31, 2026
11 checks passed
@saifsmailbox98
saifsmailbox98 deleted the saifsmailbox98-patch-1 branch July 31, 2026 23:27
@mintlify

mintlify Bot commented Aug 1, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
agent-vault 🔴 Failed Aug 1, 2026, 1:22 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants