-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Notification icon stack #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Nice idea! This will probably have to wait for a little while, as the BLE implementations for notifications currently only support the SimpleAlert and IncomingCall categories. If you want, you could try implementing support for the other categories as well. |
|
I can probably do that (separate PR), is it an issue with Gadgetbridge/companion apps, or is it something that needs to be done from the Pinetime side? |
|
Unless I'm missing something - it seems like doing that is as simple as completing the switch case at AlertNotificationService:71? Or is it more nuanced than that? Assuming that's the case - can we do it in this PR or does it need one of its own? I know we try to keep PRs to individual features per request, but it feels a bit silly to do so in this instance (though I can see the arguments for both sides) |
|
I've been running this for a few days on my watch - I did implement the switch case in AlertNotificationService, but it appears that the issue is on the companion app side - I'm using Gadgetbridge, and as @FintasticMan said, only standard notifications and calls are supported. There's also minor clipping that can occur with the icons and text if it happens to not wrap right at the edge. Either way, this PR will have to wait on support somewhere else, or we can switch to using a "standard" notification icon until that support arrives (I still find the stack quite helpful, even without icon differentiation) |
|
The icons are a little too close to the corner of the grey notification bubble, maybe it's better to have them along the bottom, and shrink the grey notification box vertically so it defines the area available for the icons better visually... |
|
To clarify, I mean something like this (a concept with #835 included, replace with the "1/5" notification counter if not included): |

This PR adds icons to the notification screen to show the types of notifications pending, and colors the one currently selected.
The UI is hidden for incoming calls as there isn't enough space.
Normal operation


Incoming call (hidden)

Shown with < 5 notifications

Known issues:
Potential Future Changes: