Desmakers 4800 i2c master controller implementation #19
+277
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinjingZhang
requested review from
NikhitaR-IFX,
jaenrig-ifx and
ramya-subramanyam
LinjingZhang
force-pushed
the
DESMAKERS-4800-i2c-master-controller-implementation
branch
from
efb3263 to
2827b05
Compare
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
LinjingZhang
force-pushed
the
DESMAKERS-4800-i2c-master-controller-implementation
branch
from
2827b05 to
e83135f
Compare
jaenrig-ifx
reviewed
Dec 8, 2025
Member
jaenrig-ifx
left a comment
jaenrig-ifx
left a comment
There was a problem hiding this comment.
Looking good!
Just a few things we can discuss tomorrow :)
Of course it is hard to validate if it fully works without a slave. But good showing up the signals and errors 👍
But we will come to that point.
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
jaenrig-ifx
reviewed
Dec 10, 2025
ports/psoc-edge/machine_i2c.h
Outdated
| #define MAX_I2C 1 | ||
| #endif | ||
|
|
||
| // Declare the I2C type for external use |
Member
There was a problem hiding this comment.
This declaration is already in extmod/modmachine.h declared. So if you include that file in you .c, this header for the time being is not required and can be deleted.
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
LinjingZhang
merged commit 96f8abc
into
MICROPY-57-enable-i2c-module-for-psoc-edge
19 checks passed
LinjingZhang
deleted the
DESMAKERS-4800-i2c-master-controller-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement basic i2c master fuction.
init()
transfer()
stop()
clean up MicroPython bindings.
Testing
write (no slave connect, so error, but you can check the logic analyzer signal):
scan (Connected to the PSOC6 I2C slave, scanning is normal, but the returned address is a bit weird. However, according to the logic analyzer results, the PSOC Edge Master's behavior is correct.):
Trade-offs and Alternatives
Pure PDL implementation, no HAL used.
But need better structure to store some device specific macro such as PCLK_SCB5_CLOCK_SCB_EN, scb_5_interrupt_IRQn...