Skip to content

Decimal number separator fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixelshade wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Decimal number separator fix #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b861a94
Decimal number separator fix
pixelshade Nov 17, 2015
0737e78
Tabs as indentation, better comment.
pixelshade Nov 18, 2015
532712d
Invariant culture set in double converting to string
Nov 18, 2015
fafce3c
Culture info set invariant, separator set to dot
Nov 18, 2015
c932354
Decimal conversion using Invariant Culture with R param
Nov 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source/Assets/Scripts/InfinarioSDK/Infinario.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ private Infinario()
{
//Prepare for wrappers
implementation = new SDK.Unity ();

//Setup decimal separator for numbers
var customCulture = (System.Globalization.CultureInfo)System.Threading.Thread.CurrentThread.CurrentCulture.Clone();
Copy link
Contributor

@ms7s ms7s Nov 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation here (spaces) does not match the surrounding code (tabs). Please use tabs so the formatting is consistent.

customCulture.NumberFormat.NumberDecimalSeparator = ".";
System.Threading.Thread.CurrentThread.CurrentCulture = customCulture;
Copy link
Contributor

@ms7s ms7s Nov 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't change a thread's culture from within the SDK, there are two reasons for that:

  • You may affect the host application, which may have set their own culture
  • The SDK runs in multiple threads and you are changing the culture for only one of them

Please use the correct Culture explicitly at the place where the string gets formatted. You want to use CultureInfo.InvariantCulture as the culture as it already has . as the decimal separator. I'm not sure about thousands separator though, please check that.

}

public static Infinario GetInstance()
Expand Down