Skip to content

refactor: extract vllm-managed-engine crate#159

Merged
BugenZhao merged 4 commits intomainfrom
bz/existing-tahr
May 6, 2026
Merged

refactor: extract vllm-managed-engine crate#159
BugenZhao merged 4 commits intomainfrom
bz/existing-tahr

Conversation

@BugenZhao
Copy link
Copy Markdown
Member

@BugenZhao BugenZhao commented May 6, 2026

Extract the code logic for spawning and monitoring the managed engine, along with the CLI args definition and repartitioning to a separate crate.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the managed engine logic into a new standalone crate, vllm-managed-engine, and updates the zeromq dependency to its official crates.io release. The CLI argument parsing for the serve command has been restructured to use the new crate's ManagedEngineArgs, and the previous serve_validate logic was replaced with a more generic repartitioning utility. Feedback from the review identifies a race condition in the ephemeral port allocation logic and recommends replacing .expect() calls in the library with structured error handling to prevent application panics.

Comment thread src/managed-engine/src/cli.rs
Comment thread src/managed-engine/src/cli.rs
@BugenZhao BugenZhao merged commit e6f9e38 into main May 6, 2026
3 checks passed
@BugenZhao BugenZhao deleted the bz/existing-tahr branch May 6, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant