refactor: extract vllm-managed-engine crate#159
Merged
Conversation
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
There was a problem hiding this comment.
Code Review
This pull request refactors the managed engine logic into a new standalone crate, vllm-managed-engine, and updates the zeromq dependency to its official crates.io release. The CLI argument parsing for the serve command has been restructured to use the new crate's ManagedEngineArgs, and the previous serve_validate logic was replaced with a more generic repartitioning utility. Feedback from the review identifies a race condition in the ephemeral port allocation logic and recommends replacing .expect() calls in the library with structured error handling to prevent application panics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the code logic for spawning and monitoring the managed engine, along with the CLI args definition and repartitioning to a separate crate.