Skip to content

chore: switch to stable toolchain#154

Merged
BugenZhao merged 2 commits intomainfrom
bz/major-chinchilla
May 4, 2026
Merged

chore: switch to stable toolchain#154
BugenZhao merged 2 commits intomainfrom
bz/major-chinchilla

Conversation

@BugenZhao
Copy link
Copy Markdown
Member

After #153, this PR furthers replaces other minor nightly features with stable alternatives. Also removed unstable options in rustfmt.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the project from a nightly Rust toolchain to a stable one by removing several nightly-only features, including trait_alias, try_blocks, and iterator_try_collect. These features are replaced with stable alternatives such as the trait-set and itertools crates, and by refactoring try blocks into async blocks or standard error handling. Additionally, the toolchain and formatting configurations have been updated to reflect this shift. Feedback includes a correction for the specified Rust version in rust-toolchain.toml, which is currently set to a non-existent version, and a suggestion to use supertraits instead of the trait-set dependency to avoid compiling multiple versions of syn and to simplify the dependency tree.

Comment thread rust-toolchain.toml
Comment thread src/chat/src/output/mod.rs
@BugenZhao BugenZhao merged commit eb2b54b into main May 4, 2026
3 checks passed
@BugenZhao BugenZhao deleted the bz/major-chinchilla branch May 4, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant