chore: Update dependencies and enhance contract testing #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the version of @inco/lightning to 'latest' in bun.lock and package.json. - Modified foundry.toml to specify test directory and patterns. - Enhanced SimpleConfidentialToken contract to require a fee for transfers. - Updated test cases for SimpleConfidentialToken to include fee handling and improved assertions.
kourtellosg
reviewed
Dec 5, 2025
contracts/package.json
Outdated
| "private": true, | ||
| "dependencies": { | ||
| "@inco/lightning": "0.6.8", | ||
| "@inco/lightning": "latest", |
Contributor
There was a problem hiding this comment.
I'm not sure If I want to have this pointing to latest instead of a specific release that we want to test
Member
Author
There was a problem hiding this comment.
Down the line, I’d prefer having this automated on every release so it always tests against the latest version. Maybe the better approach is to configure this in CI — not only to test against the latest release, but also to support a customizable environment parameter that lets us test against a specific release.
Member
Author
There was a problem hiding this comment.
reverted to 0.7.0 for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Inco-fhevm/inco-monorepo/issues/1263