feat: added updated tests for lightning #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the bun.lock file as it is no longer needed. - Updated package.json to use newer versions of @inco/lightning and @inco/js (0.6.2). - Modified lightning-test.ts to import incoLightningAbi from the correct path. - Enhanced runE2ETest function by replacing callback promise with direct call to zap.attestedDecrypt. - Added fundAccount function to facilitate account funding during tests. - Updated AddTwo contract to simplify the addTwoEOA function and removed unnecessary callback logic. - Introduced LibTest contract for testing arithmetic and logical operations on encrypted types. - Commented out test cases in TestSimpleConfidentialToken.t.sol for clarity and future reference.
- Introduced bun.lock file to manage package dependencies. - Updated @inco/lightning and @inco/js versions to 0.6.8 in package.json and contracts/package.json. - Added remapping for @inco/lightning in contracts/remappings.txt. - Added Back TestSimpleConfidentialTokent.t.sol
- Updated the Docker image tag in the .env file to v0.6.1. - Modified wagmi.config.mts to include LibTest.sol in the build process. - Refined the addTwo contract by implementing the Fee functionality and simplifying the addTwoEOA method. - Expanded the generated ABIs in abis.ts to include new functions and outputs for LibTest. - Enhanced the lightning-test.ts to incorporate tests for the new LibTest contract and its arithmetic operations.
- Changed the version of @inco/js in bun.lock to link the local package. - Added backoff configuration for retry logic in lightning-test.ts. - Integrated incoVerifierAbi into the Lightning tests for improved contract interaction. - Updated various test cases to utilize the new contract methods and ensure proper functionality. - Adjusted the LibTest contract to require a fee for encrypted input creation methods.
- Changed the version of @inco/js in bun.lock and package.json to 0.6.9. - Updated import paths in lightning-test.ts to use .js extension for generated ABIs. - Modified several test cases to ensure proper value assertions and removed unnecessary comments. - Skipped certain tests for rotation operations to focus on essential functionality.
… Lightning tests - Introduced new functions `testRevealEAddress`, `testRevealEBool`, and `testRevealEUint` in LibTest.sol for revealing encrypted values. - Updated abis.ts to include the new reveal functions. - Enhanced lightning-test.ts with tests for the new reveal functions, ensuring proper decryption and value assertions for encrypted handles. - Added a helper function to create eaddress handles for testing purposes.
kourtellosg
requested changes
Nov 10, 2025
Contributor
kourtellosg
left a comment
kourtellosg
left a comment
There was a problem hiding this comment.
looks good overall - some comments for overall improvements on test strutrure
- Updated the Docker image tag in the .env file to v0.6.9. - Changed the version of @inco/lightning in package.json to 0.6.9. - Introduced new test files for `AddTwo` and `LibTest` contracts, implementing end-to-end tests for arithmetic and logical operations. - Refactored `runE2ETest` to streamline the execution of tests for both contracts.
- Enhanced the testing workflow in test.yml by adding separate steps for installing dependencies in the root and contracts directories. - Included a step to compile contracts using Forge. - Added a step to start services with Docker. - Updated the end-to-end testing step to run tests from the backend directory.
- Added a new section to foundry.toml to disable linting during the build process.
This reverts commit 816139d.
Cm/ft fix ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.