Skip to content

fix: missing minecraft version in registry #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Conversation

NgLoader
Copy link
Member

Description

Related Issue

#41

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 18:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

zip-common/src/main/java/net/imprex/zip/common/MinecraftVersion.java:22

  • Consider adding or updating tests to verify that the new mapping for version '1.21.5' is correctly registered and can be retrieved.
MAPPINGS.add(new NmsMapping("1.21.5", "v1_21_R4"));

@NgLoader NgLoader merged commit 4596272 into master Apr 17, 2025
1 check passed
@NgLoader NgLoader deleted the fix-1.21.4-support branch April 17, 2025 18:51
@NgLoader NgLoader linked an issue Apr 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open backpack anymore
1 participant