Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of nicely styled team page: #690

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

davidorme
Copy link
Collaborator

@davidorme davidorme commented Jan 21, 2025

Description

This PR removes the team listing from README.md and now points to a new Project Team page on the website. This contains some lightly styled cards within photos and short blurb.

So you can see the results, we've set the website builder to build this branch: https://virtual-ecosystem.readthedocs.io/en/688-update-project-team/project_team.html

It's incomplete - I haven't added placeholder cards for the whole team yet. The plan is we'd like the team all to push commits to this branch to add their own details.

I've divided the details into leadership, code, data science.

Fixes #688 (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Jan 21, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (cc2e55c) to head (434e5e2).
Report is 31 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #690      +/-   ##
===========================================
+ Coverage    94.60%   94.66%   +0.05%     
===========================================
  Files           73       73              
  Lines         4800     4833      +33     
===========================================
+ Hits          4541     4575      +34     
+ Misses         259      258       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobcook1995
Copy link
Collaborator

I think this looks nice! I personally think that having longer descriptions probably removes the need for separating out into groups, but it depends what others think

@davidorme
Copy link
Collaborator Author

I think it probably makes sense to break up the grid a little and have:

Project leadership: Rob and Liv
Code development: David, Jacob, Vivi, Taran, Sally (and maybe Alex and Diego)
Data science and model parameterisation: Bai, Hao Ran, Nick, Lela (and maybe Sam)

@jacobcook1995
Copy link
Collaborator

I think it probably makes sense to break up the grid a little and have:

Project leadership: Rob and Liv Code development: David, Jacob, Vivi, Taran, Sally (and maybe Alex and Diego) Data science and model parameterisation: Bai, Hao Ran, Nick, Lela (and maybe Sam)

We also need to work out where Anna best fits as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Team
4 participants