Group expire

[jamesturner246]

Description

Automatically prune old expired group memberships.

This change adds an expiry datetime field to group membership relations. From here, we can use a django management command, scheduled as a Q task, to prune all instances of GroupMembership with expiration earlier than the current UTC time.

expiration currently default NULL, so it doesn't break stuff, and NULL means no expiration. You'll need to manually set an expiry time manually in the admin page to test.

Currently set to daily expiration checking -- modify your 0007 migration file with something shorter like the following to test it:

    Schedule.objects.update_or_create(
        name="Prune Expired Group Memberships",
        func="django.core.management.call_command",
        args=["prune_groups"],
        schedule_type="I",  # for m(I)nutes
        minutes=1,  # for one minute
    )

Also you'll need to run qcluster manually:

docker compose exec app coldfront qcluster

Tests are added, but I had to add django_q to installed apps in conftest.py, else temp db creation fails. Not sure if that's the right way.

Dunno who else to add as reviewer.

Fixes #80
Fixes #81
Fixes #91

Type of change

• Documentation (non-breaking change that adds or improves the documentation)
• New feature (non-breaking change which adds functionality)
• Optimization (non-breaking, back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Key checklist

• All tests pass (eg. python -m pytest)
• The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
• Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

[Sahil590]

Overall, the code looks fine and I have tested the expiry.

[cc-a]

Thanks @jamesturner246. Looks nice. Just need to make the field required which will probably have a few knock-on effects.

[cc-a]

Grand. Thanks @jamesturner246