Group managers UI #108
Merged
Group managers UI #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sahil590
requested review from
cc-a,
AdrianDAlessandro and
jamesturner246
and removed request for
cc-a,
AdrianDAlessandro and
jamesturner246
Sahil590
commented
Jan 22, 2025
cc-a
requested changes
Jan 23, 2025
Comment on lines
9
to
14
| {% if request.user.userprofile.is_pi or request.user == member.group_owner %} | ||
| | <a href="{% url 'imperial_coldfront_plugin:make_manager' member.pk %}">Make manager</a> | ||
| {% endif %} | ||
| {% if member.is_manager and request.user.userprofile.is_pi or member.group_owner %} | ||
| | <a href="{% url 'imperial_coldfront_plugin:remove_manager' member.pk %}">Remove manager</a> | ||
| {% endif %} |
There was a problem hiding this comment.
I believe the only logic required here is to hide both of these if is_manager is true.
There was a problem hiding this comment.
Yeah, I was overthinking this one too much.
There was a problem hiding this comment.
It also needs to hide the remove button if the member is not manger and the same with the make manager button
There was a problem hiding this comment.
I believe that only group owners, managers and superusers can access the view. Managers are the only ones that shouldn't see the links so it should be enough to check that.
cc-a
force-pushed
the
group-managers-ui
branch
from
76e5e7f to
100a189
Compare
cc-a
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two view functions for adding and removing users, respectively.
I have added a link as the HTML page doesn't look the cleanest, so can change if needed.
Fixes #73 #93 (issue)
Type of change
Key checklist
python -m pytest)python -m sphinx -b html docs docs/build)pre-commit run --all-files)Further checks