CI: Check that blog builds without warnings #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a workflow to run MkDocs in strict mode to check for build warnings and errors. Closes #25.
alexdewar
requested review from
cc-a,
SaranjeetKaur,
AdrianDAlessandro and
dc2917
cc-a
requested changes
Jul 30, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
4
to
5
| push: | ||
| branches: [main] |
There was a problem hiding this comment.
Won't this be inherently covered by the publish workflow?
There was a problem hiding this comment.
Kiiiind of. We're not building the docs in strict mode for the publish workflow though, which means warnings could creep in.
How about we just use strict mode for the publish workflow?
There was a problem hiding this comment.
That makes sense. At the moment having this workflow run on push wouldn't actually stop the publication from happening anyway so best to mae the strictness consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a workflow to run MkDocs in strict mode to check for build warnings and errors.
Closes #25.