Skip to content

workshop #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
natasharamdani wants to merge 2 commits into
base: master
Choose a base branch
from
Open

workshop #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
131e565
workshop
natasharamdani Aug 6, 2021
40a37e7
improve
natasharamdani Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func main() {
})

if err != nil {
log.StdInfo(context.Background(), nil, err, "Failed to start Log")
log.StdFatal(context.Background(), nil, err, "Failed to start Log")
}

http.HandleFunc("/", HelloHandler)
Expand All @@ -42,24 +42,24 @@ func HelloHandler(w http.ResponseWriter, r *http.Request) {
err error
)

keys, ok := r.URL.Query()["product_id"]
productIDs, ok := r.URL.Query()["product_id"]
if !ok {
log.StdFatal(ctx, nil, nil, "No product id supplied")
fmt.Fprint(w, "No product id supplied")
log.StdWarn(ctx, nil, nil, "ProductIDs not found")
fmt.Fprint(w, "ProductIDs not found")
return
}

// parse the product id
if len(keys) < 1 {
log.StdFatal(ctx, nil, nil, "No product id found")
fmt.Fprint(w, "No product id supplied")
if len(productIDs) < 1 {
log.StdWarn(ctx, nil, nil, "ProductIDs length is less than 1")
fmt.Fprint(w, "ProductIDs length is less than 1")
return
}

productID, err = strconv.Atoi(keys[0])
productID, err = strconv.Atoi(productIDs[0])
if err != nil {
log.StdFatalf(ctx, nil, nil, "Product id not valid %s", keys[0])
fmt.Fprint(w, "No product id supplied")
log.StdWarnf(ctx, nil, err, "ProductID is not integer. Key: %s", productIDs[0])
fmt.Fprint(w, "ProductID is not integer")
return
}

Expand All @@ -68,13 +68,15 @@ func HelloHandler(w http.ResponseWriter, r *http.Request) {

product, err := GetProductFromDB(ctx, productID)
if err != nil {
fmt.Fprint(w, "Invalid id")
log.StdErrorf(ctx, nil, err, "Error get product from DB. ProductID: %d", productID)
fmt.Fprint(w, "Error get product from DB")
return
}

err = CalculateDiscount(ctx, product)
if err != nil {
fmt.Fprint(w, "Invalid id")
log.StdError(ctx, product, err, "Error calculate discount")
fmt.Fprint(w, "Error calculate discount")
return
}

Expand All @@ -84,7 +86,7 @@ func HelloHandler(w http.ResponseWriter, r *http.Request) {
func GetProductFromDB(ctx context.Context, id int) (*external.Product, error) {
var result external.Product
if id < 1 {
return nil, errors.New("Product id Invalid")
return nil, errors.New("product id invalid")
}

result.Name = "product testing"
Expand All @@ -95,7 +97,7 @@ func GetProductFromDB(ctx context.Context, id int) (*external.Product, error) {
func CalculateDiscount(ctx context.Context, p *external.Product) error {
if p.Stock%2 == 0 {
p.Discount = 20
log.StdError(ctx, p, nil, "User get 20 discount")
log.StdTrace(ctx, p, nil, "User get 20 discount")
} else {
p.Discount = 0
}
Expand Down