Perf. improvements with activation and cell merge. #16251
Conversation
|
Openned rowPinning sample and pinned a row: |
|
@dkamburov First one, I was not able to reproduce: Are you sure you have the latest changes in the branch or are there any additional steps needed to reproduce? Second one is a sample issue. Because of the way the data is added, the same object refs are used in the grid sample: Hence, duplicate keys. I fixed it in the sample. |
|
@MayaKirova appologize on the non reproducible sample: I do had some changes on that sample(didn't noticed them at first as they were from my previous testing on the cell merging):
|
There was a problem hiding this comment.
Additional, issues I found:
- If you click on any of the headers in the dev sample an error is thrown.
- Go to the performance project and enable the merging on all columns. Run the performance samples using
npm run start:performanceand go to the grid with 1 million records. Sort thePositioncolumn. Click on the first cell of theRegisteredcolumn. An error is thrown with maximum callstack exceeded.
3. For 1 million records on the performance sample, it takes 4 to 5 seconds to merge the cells. Sometimes the browser crashes out of memory. This makes all other features that are pipe related to feel very slow.
| activeRowIndexes = activeRowIndexes.map(x => x - this.grid.pinnedRecordsCount); | ||
| } | ||
| const result = DataUtil.merge(cloneArray(collection), colsToMerge, mergeStrategy, activeRowIndexes, this.grid); | ||
| activeRowIndexes = activeRowIndexes.filter((val, idx, arr) => arr.indexOf(val) === idx).filter(x => !isNaN(x)); |
There was a problem hiding this comment.
If this is only removing the duplicates can we use a set? Probably, it would be too much of a work to refactor everywhere activeRowIndexes is used but you can use it here like :
Array.from(new Set(activeRowIndexes)).filter(x => !isNan(x));
| } | ||
| }); | ||
| }); | ||
| const uniqueRoots = rootsToUpdate.filter((val, idx, arr) => arr.indexOf(val) === idx); |
There was a problem hiding this comment.
rootsToUpdate can be a Set here as well
There was a problem hiding this comment.
Changes are applied and issues should be solved. The performance comments is up for discussion I guess.
Closes #16146
Split pipes in two, where one does the merging and the other tracks active rows and unmerges within related merge sequences.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)