Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid validate filtering expressions tree #15564

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

hanastasov
Copy link
Contributor

@hanastasov hanastasov commented Mar 21, 2025

Closes #15563

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

@gedinakova gedinakova requested a review from Otixa March 21, 2025 13:44
@gedinakova
Copy link
Contributor

gedinakova commented Mar 21, 2025

@Otixa Hristo's scenario is actually a little different. The idea is that we may have a scenario in which a grid field is, let's say, no longer available. This would lead to breaking the user's app because the expression tree has not been checked & updated accordingly. Maybe it's not that bad to simply show an empty grid which would hint them into the direction there's something wrong with the filters.

@deyvidnenchev deyvidnenchev added the ✅ status: verified Applies to PRs that have passed manual verification label Mar 24, 2025
@hanastasov hanastasov removed the ❌ status: awaiting-test PRs awaiting manual verification label Mar 24, 2025
@hanastasov hanastasov merged commit 0557841 into master Mar 24, 2025
2 of 12 checks passed
@hanastasov hanastasov deleted the grid-validate-filteringExpressionsTree branch March 24, 2025 13:10
@hanastasov
Copy link
Contributor Author

hanastasov commented Mar 24, 2025

Oh i;m such a rookie - fix should be "

        if (expr.condition.logic) {
            return expr.condition?.logic(val, expr.searchVal, expr.ignoreCase);
        }

will make a new pr #15568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filtering grid ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid throws if passed an expressionTree with a field name that does not exist in Grid.
4 participants