Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GridBase): Apply spec for server-side rendering for relative gri… #15556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MayaKirova
Copy link
Contributor

…d sizes.

Closes #15202

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova
Copy link
Contributor Author

@dkamburov @ChronosSF

FYI, the grid will now retain 100% size (width/height) from the SSR render, however note that things inside the grid may still flicker during hydration on the client.

For example:

  • Scrollbars may show, since we're going from an empty grid to a grid with data.

  • Columns that have relative size (in %), may change their size after hydration (and as a result of that also spawn a scrollbar). This makes sense because they were originally measured to the size the sever has used for pre-render.

    So it looks similar to this, when hydration occurs:
    grid_hydration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR Grid Improvements
2 participants