Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering expression throwing error with no columns. Related fixes for elements Blazor grid. #15523

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix filtering expression throwing error with no columns. Related fixes for elements Blazor grid. #15523

wants to merge 5 commits into from

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Mar 14, 2025 •
edited
Loading

Closes #15527

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@skrustev skrustev added 🛠️ status: in-development Issues and PRs with active development on them 💠 grid: elements version: 19.2.x labels Mar 14, 2025
@skrustev skrustev changed the title Skrastev/filtering expr fixes Enable filtering expression conditionName only use. Related fixes for elements Blazor grid. Mar 14, 2025
@skrustev skrustev dismissed Otixa’s stale review March 17, 2025 12:50

The property condition is no longer required.

@skrustev skrustev marked this pull request as ready for review March 19, 2025 15:36
@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 19, 2025
@skrustev skrustev changed the title Enable filtering expression conditionName only use. Related fixes for elements Blazor grid. Fix filtering expression throwing error with no columns. Related fixes for elements Blazor grid. Mar 20, 2025
@tishko0 tishko0 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayaKirova MayaKirova MayaKirova approved these changes

@gedinakova gedinakova gedinakova approved these changes

@Otixa Otixa Otixa approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

Assignees

@dkamburov dkamburov

@tishko0 tishko0

Labels
💥 status: in-test PRs currently being tested 💠 grid: elements grid: global-filtering version: 19.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting Filtering Expression Tree without condition function throws error if columns are not yet defined
6 participants
@skrustev @MayaKirova @gedinakova @Otixa @dkamburov @tishko0