Skip to content

Conversation

@jschmidt-icinga
Copy link
Contributor

@jschmidt-icinga jschmidt-icinga commented Oct 17, 2025

Together with #9411, #9728, #9729 and #9730 this fixes most of the remaining compiler warnings, except the following:

  • A few -Wdangling-reference in scheduleddowntime-apply.cpp, which I'm pretty sure are false positives.
  • The OpenSSL 3.0 -Wdeprecated-declarations warnings.
  • The '-Wdeprecated' warnings about %pure-parser being deprecated in the .yy parser files. At first I wanted to include them here, but despite things seemingly building fine it seems there's some additional implications with replacing %pure-parser with %define api.pure and %error-verbose with %define parse.error verbose that I can't judge because I'm not a bison expert.
  • Possibly lots of platform specific stuff I've missed (didn't test with clang and we don't enable many warnings on Windows to begin with)

Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This currently duplicates some of the efforts in #9411 until that is merged.

Suggestion:

  1. Rebase #10609 on top of #9411
  2. Change your base branch from master to compiler-warnings

@Al2Klimov Al2Klimov self-requested a review October 20, 2025 08:28
@jschmidt-icinga jschmidt-icinga force-pushed the fix-misc-compiler-warnings branch from 05b635d to a25c3f1 Compare October 21, 2025 13:26
@jschmidt-icinga jschmidt-icinga force-pushed the fix-misc-compiler-warnings branch from a25c3f1 to 289607b Compare October 21, 2025 13:44
@Al2Klimov Al2Klimov removed their request for review October 21, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants