[BUGFIX] Check BackendUtility::getRecord before using it in array_merge #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IchHabRecht
reviewed
Jul 30, 2025
| if (!empty($record)) { | ||
| $incomingFieldArray = array_merge($record, $incomingFieldArray); | ||
| } | ||
| $incomingFieldArray = array_merge(BackendUtility::getRecord('tt_content', $id), $incomingFieldArray); |
Owner
There was a problem hiding this comment.
it seems you doing the same thing twice now?
Author
There was a problem hiding this comment.
@IchHabRecht You're right. I forgot to delete the original line. The commit is updated. Thanks.
mikelwohlschlegel
force-pushed
the
bugfix/null-check-get-record-before-array-merge
branch
from
00a07c7 to
4503e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks BackendUtility::getRecord before using it in array_merge to avoid an exception.
We had the following problem:
There seems to be a difference in processing a history rollback between v11 und v12.
Steps to reproduce:
v11 --> WORKS
v12 --> EXCEPTION
While step debugging, I found out that $datamap['tt_content'] in
content_defender/Classes/Hooks/DatamapDataHandlerHook.php
Line 34 in dab78e7
My guess is, that v12 processes every single step in v12, while v11 just deletes the newly added elements (not proofed).
I'm not sure if this can maybe cause some side affects? What is the intention of merging the arrays here?