[FEATURE] Allow to restrict number of items by CType #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhovratov
force-pushed
the
feature-maxitem-by-ctype
branch
from
f7bce56 to
d44e814
Compare
nhovratov
force-pushed
the
feature-maxitem-by-ctype
branch
from
d44e814 to
d4a006e
Compare
Author
|
@IchHabRecht Hi Nicole, what do you think about this patch? I think the feature itself is very benefitial and doesn't require a lot of code changes. Basically, instead of caching uid => uid in the runtime cache, we use uid => cType. The remaining part is just adding the additional constraint checks. Would love to hear your feedback on this. |
Author
|
@IchHabRecht Hi again, I would really love to see that feature in Content Defender. Will you be able to have a look at my patch anytime soon? Greetings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #170