Merged
Conversation
Update sanitizeCommitMessage() to properly escape backslashes before escaping double quotes. Ensures commit messages with both characters are handled correctly when passed to git commands. Release-Note: properly escapes backslashes and double quotes in commit messages to prevent malformed input to git Signed-off-by: Ian Skelskey <[email protected]>
- Sets explicit permissions in format.yml, pre-publish.yml, and publish.yml workflows - Grants write permissions for contents and pull-requests in format.yml for better automation support - Restricts pre-publish.yml and publish.yml to read-only contents access for security - Grants actions: write permission to the test job in pre-publish.yml to enable artifact uploads Release-Note: add and clarify GitHub Actions workflow permissions for improved security and functionality Signed-off-by: Ian Skelskey <[email protected]>
- Bump version from 0.3.0 to 0.3.1 in package.json, README.md, and main.ts. - Update CHANGELOG.md with summary of changes for 0.3.1. - Minor cleanup: remove unnecessary space from pre-publish.yml permissions. - No functional code changes introduced (version bump and documentation only). Release-Note: release version 0.3.1 with updated security permissions in workflows and commit message sanitizer fix Signed-off-by: Ian Skelskey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to GitHub Actions workflows to adjust permissions for various jobs and includes a bug fix in the
src/util/git.tsfile to improve commit message sanitization.Workflow permissions updates:
.github/workflows/format.yml: Addedcontents: writeandpull-requests: writepermissions to enable the workflow to modify repository contents and interact with pull requests..github/workflows/pre-publish.yml: Addedcontents: readpermissions to theonsection andcontents: readandactions: writepermissions to thetestjob to support artifact uploads. [1] [2].github/workflows/publish.yml: Addedcontents: readpermissions to allow the workflow to read repository contents.Bug fix in commit message sanitization:
src/util/git.ts: Updated thesanitizeCommitMessagefunction to first escape backslashes before escaping double quotes, ensuring proper handling of special characters in commit messages.