Gives space carp visible feet - #355
Open
Danservfinn wants to merge 1 commit into
Open
Conversation
Adds a small pair of pixel-art feet beneath the space carp's body in all cardinal directions for the standard living carp states. Changes: - icons/mob/simple/carp.dmi: Added 2x2 pixel feet to the 'carp' (full color), 'base' (greyscale), 'base_mouth', 'disk_mouth', 'disk_overlay', 'magic_eyes', 'base_friend', and 'base_friend_mouth' icon states across all 4 directions and all animation frames. - Feet are positioned beneath the body center for S/N directions, and as front/back pairs for E/W directions. - Greyscale states use medium-grey feet (180,180,180) so they tint correctly with the carp's body color through the greyscale config system. - Full-color states use dark brown (55,45,38) matching the carp's shading. - No gameplay statistics, combat, movement, or AI behavior changed. - Dead, gib, and swell states are intentionally untouched. Implements bounty: Iamgoofball#340
15 tasks
|
Can we add legs too? 👉👈🥺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Resolves #340.
This PR adds a small pair of pixel-art feet beneath the standard living space carp's body, visible at normal gameplay zoom. The feet appear naturally attached beneath the body and remain correctly aligned across all four facing directions and all animation frames.
Visual approach
The feet are a matched pair of 2×2 pixel squares positioned just below the body's lowest opaque row. For South and North facing directions, the feet are placed symmetrically beneath the body center. For East and West (profile views), the feet are placed as a front/back pair spanning the body's horizontal extent.
Implementation details
Icon states modified (in
icons/mob/simple/carp.dmi):carpbasemagic_eyesbase_mouthdisk_mouthdisk_overlaybase_friendbase_friend_mouthColor handling:
base,base_mouth,disk_mouth,disk_overlay,base_friend,base_friend_mouth) use medium-grey pixels (180,180,180). This ensures the feet are tinted correctly at runtime via the/datum/greyscale_config/carpconfig, so they always match the carp's body color.carp,magic_eyes) use dark brown (55,45,38) to match the carp's existing shading palette.States NOT modified:
carp_dead,base_dead,base_dead_mouth,base_friend_dead— dead carp don't need feet standingcarp_gib,magicarp_gib— gibs don't have feetcarp_swell— swell animation is brief and doesn't show feetholocarp— holographic variant already has distinct appearanceNo gameplay changes
This is purely a visual/sprite change. No DM code was modified. Combat statistics, movement speed, AI behavior, pathfinding, health, faction behaviour, and all other gameplay properties are completely unchanged. The feet are part of the sprite itself, not a code-driven overlay.
Why It's Good For The Game
Space carp have long suffered from a conspicuous absence of feet. This PR addresses that anatomical oversight with a subtle, style-consistent addition that enhances the carp's visual character without disrupting its iconic silhouette.
Testing
Before/after: The feet appear as a small matched pair beneath the body in every living directional state. They are understated but clearly legible at normal zoom.
Changelog
🆑
image: Space carp now have visible feet
/:cl: