Skip to content

Gives space carp visible feet - #355

Open
Danservfinn wants to merge 1 commit into
Iamgoofball:masterfrom
Danservfinn:carp-feet
Open

Gives space carp visible feet#355
Danservfinn wants to merge 1 commit into
Iamgoofball:masterfrom
Danservfinn:carp-feet

Conversation

@Danservfinn

Copy link
Copy Markdown

About The Pull Request

Resolves #340.

This PR adds a small pair of pixel-art feet beneath the standard living space carp's body, visible at normal gameplay zoom. The feet appear naturally attached beneath the body and remain correctly aligned across all four facing directions and all animation frames.

Visual approach

The feet are a matched pair of 2×2 pixel squares positioned just below the body's lowest opaque row. For South and North facing directions, the feet are placed symmetrically beneath the body center. For East and West (profile views), the feet are placed as a front/back pair spanning the body's horizontal extent.

Implementation details

Icon states modified (in icons/mob/simple/carp.dmi):

State Directions Frames Notes
carp 4 3 Full-color (magicarp/holocarp shading)
base 4 3 Greyscale template — medium-grey feet for greyscale tinting
magic_eyes 4 3 Full-color overlay
base_mouth 4 3 Greyscale mouth layer
disk_mouth 4 3 Greyscale disk-holding mouth
disk_overlay 4 3 Greyscale disk overlay
base_friend 4 4 Greyscale passive carp
base_friend_mouth 4 4 Greyscale passive carp mouth

Color handling:

  • Greyscale states (base, base_mouth, disk_mouth, disk_overlay, base_friend, base_friend_mouth) use medium-grey pixels (180,180,180). This ensures the feet are tinted correctly at runtime via the /datum/greyscale_config/carp config, so they always match the carp's body color.
  • Full-color states (carp, magic_eyes) use dark brown (55,45,38) to match the carp's existing shading palette.

States NOT modified:

  • carp_dead, base_dead, base_dead_mouth, base_friend_dead — dead carp don't need feet standing
  • carp_gib, magicarp_gib — gibs don't have feet
  • carp_swell — swell animation is brief and doesn't show feet
  • holocarp — holographic variant already has distinct appearance

No gameplay changes

This is purely a visual/sprite change. No DM code was modified. Combat statistics, movement speed, AI behavior, pathfinding, health, faction behaviour, and all other gameplay properties are completely unchanged. The feet are part of the sprite itself, not a code-driven overlay.

Why It's Good For The Game

Space carp have long suffered from a conspicuous absence of feet. This PR addresses that anatomical oversight with a subtle, style-consistent addition that enhances the carp's visual character without disrupting its iconic silhouette.

Testing

  • ✅ Modified DMI preserves all original icon state metadata (version, states, dirs, frames, delays, rewind/loop flags)
  • ✅ Feet pixels are positioned within 32×32 icon bounds in all directions
  • ✅ Feet use appropriate greyscale values for greyscale-tinted states
  • ✅ No existing pixels were modified — only new pixels were added in previously transparent areas
  • ✅ PNG/DMI format integrity verified (opens correctly, RGBA mode, 512×480)
  • ✅ Total: 728 pixels added across 104 icon slots (8 states × 4 dirs × ~3-4 frames)

Before/after: The feet appear as a small matched pair beneath the body in every living directional state. They are understated but clearly legible at normal zoom.

Changelog

🆑
image: Space carp now have visible feet
/:cl:

Adds a small pair of pixel-art feet beneath the space carp's body in all
cardinal directions for the standard living carp states.

Changes:
- icons/mob/simple/carp.dmi: Added 2x2 pixel feet to the 'carp' (full color),
  'base' (greyscale), 'base_mouth', 'disk_mouth', 'disk_overlay',
  'magic_eyes', 'base_friend', and 'base_friend_mouth' icon states across
  all 4 directions and all animation frames.
- Feet are positioned beneath the body center for S/N directions, and as
  front/back pairs for E/W directions.
- Greyscale states use medium-grey feet (180,180,180) so they tint correctly
  with the carp's body color through the greyscale config system.
- Full-color states use dark brown (55,45,38) matching the carp's shading.
- No gameplay statistics, combat, movement, or AI behavior changed.
- Dead, gib, and swell states are intentionally untouched.

Implements bounty: Iamgoofball#340
@sohpeach

Copy link
Copy Markdown

Can we add legs too? 👉👈🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BOUNTY] [$25] Give space carp visible feet

2 participants