Guard _send_oncall_summary against None trading_bot (prod branch)#58
Merged
IamJasonBian merged 1 commit intoIamJasonBian/render-prod-dry-runfrom May 8, 2026
Conversation
In publish-only/headless Render deploys, trading_bot is None when RH credentials are absent. _send_oncall_summary called .get_pdt_status() unconditionally, raising AttributeError after every successful blob upload. The existing 'PDT: unavailable' branch already handles None, so the fix is a single ternary guard.
IamJasonBian
merged commit fa30324
into
IamJasonBian/render-prod-dry-run
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IamJasonBian/render-prod-dry-run— the branch that the Render workersrv-d70trd15pdvs739ic1dgactually tracks.-v1by mistake.Test plan
[oncall] Error sending Slack summaryno longer appears in logs and the Slack summary posts withPDT: unavailable.