IGDD-3013: Fix Content-Location header in bulk export kickoff - #5
Merged
Conversation
Module builds standalone as a library JAR for CI/CD and GitHub Packages publication. Clarify distinction between standalone library build and full SQL-enabled service image build in izgw-transform. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds the standard IZ Gateway library CI/CD workflow (build, test, deploy to GitHub Packages on develop). Updates pom.xml with repository declarations, distribution management, and test/web/lombok dependencies needed for Stage 1B. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ACTIONS_KEY is only needed for protected-branch pushes (not needed here). packages: write permission enables cross-repo package reads via GITHUB_TOKEN. Remove doRevisionCheck which requires custom plugin configuration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3.2.0-SNAPSHOT is actively published by izgw-core develop CI and used successfully by izgw-transform. 3.1.0 was never deployed to GitHub Packages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Matches izgw-transform pattern: izgateway (not IZGateway). GitHub Packages URLs are case-sensitive on the org segment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- AutoConfiguration.imports registering SqlBackendAutoConfiguration
- SqlFhirController: /sql/fhir/{name}/** returning empty Bundles (Stage 1)
- SqlUnavailableController: /sql/** and /bulk/sql/** return 503 when SQL absent
- BulkExportJob model with Status enum and OutputFile inner class
- BulkExportJobStore and BulkExportOutputStore interfaces
- InMemoryBulkExportJobStore (V1, single-instance)
- TempFileBulkExportOutputStore (V1, single-instance)
- BulkExportController: POST /bulk/sql/fhir/$export, GET/DELETE $export-status
- Unit tests for SqlFhirController and BulkExportController
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…fixture - SqlMappingConfiguration, ResourceMapping, ConceptMapEntry model classes - SqlMappingConfigLoader (YAML from classpath or external path) - sql-mapping.yml default mapping for patient/immunization CSV columns - SqlTableMapper<T> abstract base with primitive/complex type converters - SqlPatientRowMapper and SqlImmunizationRowMapper - TabularFhirConverter Bundle assembler - SqlDevBackend CSV-backed fixture (no JDBC required) - SqlBackendProperties @ConfigurationProperties - SqlBackendAutoConfiguration wiring - Unit tests for all components (21 tests passing) - Test CSV fixtures in src/test/resources/sql-dev/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… paths AccessControlRegistry (in izgw-core) must be called with register(this) so AccessControlValve allows /sql/** and /bulk/sql/** paths. Without registration, all paths return 401. No circular dependency since AccessControlRegistry lives in izgw-core which we already depend on. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Includes all_vax_event enriched mapping (61-column schema with FHIR targets), published data dictionary, Databricks notebook source, and folder README. These are the canonical inputs for sql-mapping.yml generation (task 2.3a) and test data transformation (task 2.3c). PPTX excluded as binary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rd fhir/ docs - index.md: overview, relationship to hub-routed FHIR, how-it-works flow diagrams - sql-fhir-api.md: single-patient query endpoints, _lastUpdated filtering, patient match - bulk-fhir-api.md: full lifecycle, temporal filtering, V1 limitations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- aws-sql-deployment.md: task def rev 3, cert issued, ECS service live, ECR transformation-service-sql repo documented with Inspector scanning - sql-fhir-api.md: Stage 1 implementation status note (empty Bundle stage) - sql-fhir/index.md and bulk-fhir-api.md: accurate as written Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…strings The constructor-based AccessControlRegistry.register(this) approach was not registering paths. Use SmartInitializingSingleton in SqlBackendAutoConfiguration to explicitly register all /sql/** and /bulk/sql/** paths after the full context is ready. Also fix @RolesAllowed strings from XFORM_SENDING_SYSTEM/ADMIN to the actual values xform-sender/admin (matching Roles constants in izgw-transform). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…egistration spring.main.lazy-initialization=true in izgw-transform means all beans default to lazy. SqlFhirController and BulkExportController were never instantiated before the first request arrived, so register(this) was never called and the AccessControlRegistry had empty roles for /sql/** paths. FhirController correctly has @lazy(false) for exactly this reason. Also reverts the SmartInitializingSingleton workaround — @lazy(false) is the proper fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Bulk FHIR spec requires Content-Location, not Location. ResponseEntity.location() sets Location; use .header() instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Content-Location (not Location) header per Bulk FHIR spec. Update unit test accordingly.