IGDD-3084: consume izgw-core's auto-detected swagger-ui version, drop the stale yaml pin - #185
Open
tmy1313 wants to merge 3 commits into
Open
IGDD-3084: consume izgw-core's auto-detected swagger-ui version, drop the stale yaml pin#185tmy1313 wants to merge 3 commits into
tmy1313 wants to merge 3 commits into
Conversation
… the stale yaml pin application.yml hand-pinned springdoc.swagger-ui.version to a literal that had to be manually re-edited every time izgw-bom's nightly job bumped org.webjars:swagger-ui, and it wasn't happening reliably -- the pin had already drifted (5.32.13 pinned vs. 5.32.14 actually resolved), and /swagger/ui.html was 404ing. izgw-core now detects the real webjar version at startup instead, so the pin is removed entirely. Added SwaggerUiVersionIntegrationTests to prove Hub's own application context actually inherits the fix via component scan, not just that the mechanism exists in izgw-core.
…ange
docs/superpowers/{plans,specs}/*.md were working notes generated while
drafting this change; the OpenSpec proposal/design docs already carry the
same content in this repo's own convention, so the separate copies were
redundant. Updated the two dangling references accordingly.
Code review correctly flagged that the documented test/verification trail (174 tests, TC_92a/TC_92b) ran against izgw-core:3.5.1-IGDD-2353_spring_upgrade-SNAPSHOT, not the 3.6.0-IGDD-3084_swagger_ui_version_sync-SNAPSHOT actually committed in pom.xml -- a leftover from before the branch-placement move. Cleared the local .m2 cache for that exact coordinate, forced a fresh fetch from GitHub Packages (now that the izgw-core PR has published it), and reran the full suite against it: 174 tests, 0 failures, BUILD SUCCESS. tasks.md updated to document this accurately instead of the stale trail.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application.ymlhand-pinnedspringdoc.swagger-ui.version: 5.32.13, butizgw-bomindependently bumpsorg.webjars:swagger-uion its own nightly schedule, so the pin drifted (actual resolved version:5.32.14) and/swagger/ui.html//swagger/swagger-ui/index.html404'd.izgw-core(IGDD-3084: auto-detect swagger-ui webjar version instead of hand-pinning it izgw-core#95): aBeanPostProcessorthat detects the real webjar version on the classpath at startup and overrides Springdoc's config with it, so there's no longer a second value to keep in sync. Removes the stale yaml pin entirely.SwaggerUiVersionIntegrationTeststo prove Hub's own application context actually inherits the fix via component scan (not just that the mechanism exists inizgw-core).openspec/changes/igdd-3084-swagger-ui-version-sync/(proposal, design, tasks, capability spec).Depends on IZGateway/izgw-core#95 — this PR's
pom.xmlalready points at that PR's published SNAPSHOT (3.6.0-IGDD-3084_swagger_ui_version_sync-SNAPSHOT), verified to resolve from GitHub Packages.Unrelated to the Spring Boot 4 migration (IGDD-2353) — same root cause and fix regardless of Spring Boot version; git history shows this exact drift-and-repatch cycle recurring since May, months before that migration branch existed.
Test plan
mvn clean test— 174 tests, 0 failures, 0 errors,BUILD SUCCESS(verified against the real publishedizgw-coreartifact, not a local build)SwaggerUiVersionIntegrationTestspasses; startup log confirmsDetected swagger-ui webjar version: 5.32.14TC_92a Get DocumentationandTC_92b Get Api Document(Postman, via newman with a real client cert) both return 200