Fix NPE and DocumentBuilder race in HubClientFault/XmlUtils - #92
Open
ebrockainq wants to merge 1 commit into
Open
Fix NPE and DocumentBuilder race in HubClientFault/XmlUtils#92ebrockainq wants to merge 1 commit into
ebrockainq wants to merge 1 commit into
Conversation
documentElementIsError() called getFirstChild().getNodeName() without checking getFirstChild() for null, causing an NPE when building fault messages for destination SOAP faults. XmlUtils shared a single static DocumentBuilder across all threads; DocumentBuilder isn't thread-safe, so concurrent parseDocument() calls could corrupt parser state and return a document with no children, triggering the NPE above. Switched to a ThreadLocal<DocumentBuilder>. Added tests for both issues and verified against the pre-fix code to confirm they reproduce the original bugs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
documentElementIsError() called getFirstChild().getNodeName() without checking getFirstChild() for null, causing an NPE when building fault messages for destination SOAP faults.
XmlUtils shared a single static DocumentBuilder across all threads; DocumentBuilder isn't thread-safe, so concurrent parseDocument() calls could corrupt parser state and return a document with no children, triggering the NPE above. Switched to a ThreadLocal.
Added tests for both issues and verified
against the pre-fix code to confirm they reproduce the original bugs.