Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor [#131] 응답에서 불필요한 Validation 제거 및 속성 이름 통일 #132

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Refactor [#131] 응답에서 불필요한 Validation 제거 및 속성 이름 통일 #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b7695
Refactor [#131] updateAt -> updatedAt
kych4n Mar 10, 2025
38e7f0f
Refactor [#131] 응답에서 불필요한 Validation 제거
kych4n Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...ava/org/cotato/tlinkserver/domain/homework/application/dto/response/HomeworkResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,10 @@

import org.cotato.tlinkserver.domain.homework.Homework;

import jakarta.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotNull;

public record HomeworkResponse(
@NotNull
Long homeworkId,
@NotBlank
String homeworkName,
@NotBlank
String createdAt,
@NotBlank
String deadline,
boolean passed
)
Expand Down
2 changes: 1 addition & 1 deletion ...otato/tlinkserver/domain/lectureFile/application/dto/response/LectureFileBoxResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public record LectureFileBoxResponse
(
Long lectureFileBoxId,
String lectureFileBoxName,
String updateAt
String updatedAt
)
{
public static LectureFileBoxResponse from(final LectureFileBox lectureFileBox) {
Expand Down
4 changes: 0 additions & 4 deletions ...in/java/org/cotato/tlinkserver/domain/room/application/dto/response/RoomDataResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,12 @@
import org.cotato.tlinkserver.domain.room.Room;
import org.cotato.tlinkserver.domain.user.User;

import jakarta.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotNull;
import lombok.Builder;

@Builder
public record RoomDataResponse
(
@NotNull
Room room,
@NotBlank
String roomName,
User user
)
Expand Down
9 changes: 0 additions & 9 deletions .../java/org/cotato/tlinkserver/domain/room/application/dto/response/RoomModifyResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,17 @@
import org.cotato.tlinkserver.domain.room.Registration;
import org.cotato.tlinkserver.domain.room.Room;

import jakarta.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotNull;
import lombok.Builder;

@Builder
public record RoomModifyResponse
(
@NotNull
Long roomId,
@NotBlank
String roomName,
@NotBlank
String studentName,
@NotBlank
String subject,
@NotNull
List<LessonDayModifyResponse> lessonDays,
@NotNull
PermissionResponse parentPermission,
@NotNull
PermissionResponse studentPermission
)
{
Expand Down