#8614 Added notes for Oxford Instruments - Mercury IPS controller #8831
Conversation
…upport module changes
iangillingham-stfc
changed the title
|
|
||
| | Ticket | Type | Device | Change | | ||
| | ------ | --- |------| ------------- | | ||
| |[#8614](https://github.com/ISISComputingGroup/IBEX/issues/8614) | Major | Oxford Instruments - Mercury IPS| Added support for SCPI mode to use the full capabilities of the new Mercury IPS magnet supplies| |
There was a problem hiding this comment.
The change types (noted lower down in the release notes) are:
Change Types:
- Major - Backward compatible breaking change
- Minor - Change in API/functionality
- Patch - Bug fix no change in functionality
I think as we made an effort explicitly to remain backwards compatible, this is actually a "minor" change - we are providing new functionality (ability to use SCPI mode) but not breaking existing use of the legacy mode (or the old controllers which only support legacy commands).
(The change types don't necessarily reflect "amount of work" - we have in the past made 1-line PRs which are "major", and also made thousands of lines of changes which are a "patch" if they don't affect user-facing workflows at all)
There was a problem hiding this comment.
Yes - agreed. I was in a quandary about that. Originally I wrote 'minor', but it didn't "feel" minor. You're absolutely correct though, it's not a breaking change at all. I'll change it.
No description provided.