-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict/Unrestrict File Feature in File Page #617
Open
ChengShi-1
wants to merge
6
commits into
develop
Choose a base branch
from
613-restrict-file-feature-in-files-tab-and-files-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Restrict/Unrestrict File Feature in File Page #617
ChengShi-1
wants to merge
6
commits into
develop
from
613-restrict-file-feature-in-files-tab-and-files-page
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...edit-file-menu/restrict-file-button/confirm-restrict-file-modal/ConfirmRestrictFileModal.tsx
Outdated
Show resolved
Hide resolved
...edit-file-menu/restrict-file-button/confirm-restrict-file-modal/ConfirmRestrictFileModal.tsx
Show resolved
Hide resolved
src/sections/file/file-action-buttons/edit-file-menu/restrict-file-button/useRestrictFile.tsx
Outdated
Show resolved
Hide resolved
tests/component/sections/file/file-action-buttons/edit-file-menu/EditFileMenu.spec.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 18
FY25 Sprint 18 (2025-02-26 - 2025-03-12)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: File Page
SPA.Q1.6
Files Page: Files Edit Options
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement the Restrict/Unrestrict Feature for a single file
Which issue(s) this PR closes:
Special notes for your reviewer:
Some changes need to know:
isHeader
toEditFileOptions
.isHeader == true
means it's the EditFileOptions button existing in the header of filesTable, dealing with multiple files.isHeader == false
means it is one of the file in files, dealing with a single file.Suggestions on how to test this:
create a dataset > upload file
click into the file page, Edit File > Restrict
A modal should be shown

(input box and checkbox are both disabled, waiting for api )
Please notice that
Restrict Access
andTerms of Access
are hard-coded, not connect to api yetSave Changes, a toast should be shown. then check if the file is restricted by checking if a Unlock Icon is shown on dataset page > File tab

click into the file page, Edit File > Unrestrict, a modal shown
lOG
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: