Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Collection - SPA integration #605

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Feb 17, 2025

What this PR does / why we need it:

Replicate JSF Delete Collection functionality.
Also added copy labels github action workflow.

Which issue(s) this PR closes:

Suggestions on how to test this:

Step 1: Run the Development Environment

  1. Execute npm i.
  2. Navigate with cd packages/design-system && npm i && npm run build.
  3. Return with cd ../../.
  4. Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
  5. Navigate with cd dev-env.
  6. Start the environment using ./run-env.sh unstable.
  7. To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the feature

  1. Verify that in the root collection edit dropdown there is no Delete Collection button (even if it has no collections or datasets in it)
  2. Create a collection and verify that in the edit dropdown there is a Delete Collection button.
  3. Delete the collection, a toast message should appear and you should be redirected to the parent collection.
  4. Create again a collection ("Test Collection") and verify that in the edit dropdown there is a Delete Collection button.
  5. Create a dataset or a collection within "Test Collection".
  6. Navigate to "Test Collection" and verify that in the edit dropdown there is NO Delete Collection button as the collection now has data in it.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes.
Screen Shot 2025-02-17 at 12 03 31
Screen Shot 2025-02-17 at 12 03 40

Is there a release notes update needed for this change?:

No.

Additional documentation:

No.

@github-actions github-actions bot added FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) GREI Re-arch GREI re-architecture-related SPA.Q1.7 Collection Page: Delete Collection SPA: Collection Page Waiting labels Feb 17, 2025
@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Feb 17, 2025
@g-saracca g-saracca changed the title Feat/602 delete collection Delete Collection - SPA integration Feb 17, 2025
@coveralls
Copy link

coveralls commented Feb 17, 2025

Coverage Status

coverage: 97.716% (+0.5%) from 97.241%
when pulling ff05ab7 on feat/602-delete-collection
into fa6299a on develop.

@g-saracca g-saracca removed the Waiting label Feb 26, 2025
@ekraffmiller
Copy link
Contributor

@g-saracca there are merge conflicts, can you resolve?

@g-saracca
Copy link
Contributor Author

@ekraffmiller , they are just js-dataverse package conflicts, I will resolve them after the Delete File SPA Integration is merged if its ok with you, to avoid solving conflicts twice.

@cmbz cmbz added the FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) label Feb 27, 2025
@ChengShi-1 ChengShi-1 self-requested a review February 27, 2025 14:28
@ChengShi-1 ChengShi-1 self-assigned this Feb 27, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspect the code and test the function on the page. Everything great! just a tiny tweak

@g-saracca
Copy link
Contributor Author

@ChengShi-1 change made, thanks!

Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. approve:)

@ChengShi-1 ChengShi-1 removed their assignment Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page SPA.Q1.7 Collection Page: Delete Collection
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

Collection Page: Delete Collection
5 participants