-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Collection - SPA integration #605
base: develop
Are you sure you want to change the base?
Conversation
@g-saracca there are merge conflicts, can you resolve? |
@ekraffmiller , they are just js-dataverse package conflicts, I will resolve them after the Delete File SPA Integration is merged if its ok with you, to avoid solving conflicts twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inspect the code and test the function on the page. Everything great! just a tiny tweak
tests/component/sections/collection/edit-collection-dropdown/EditCollectionDropdown.spec.tsx
Outdated
Show resolved
Hide resolved
@ChengShi-1 change made, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. approve:)
What this PR does / why we need it:
Replicate JSF Delete Collection functionality.
Also added copy labels github action workflow.
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm i && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.


Is there a release notes update needed for this change?:
No.
Additional documentation:
No.