-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #100 from IQSS/dev
Releasing 0.3.8
- Loading branch information
Showing
2 changed files
with
26 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,40 @@ | ||
Description | ||
----------------------------------------------- | ||
|
||
In response to a January notification from Brian Ripley, the tests are now skipped if the server cannot be contacted. Unfortunately I couldn't attend to this package quickly enough, and understandably it was archived a few days ago. | ||
After Brian Ripley's latest instructions, we have decided we shouldn't rely | ||
on nightly CRAN builds for testing the package's interactions with servers. | ||
Even if the servers are reachable. All those tests are now skipped on CRAN | ||
(with `testthat::skip_on_cran()`) and instead will run on nightly | ||
GitHub Actions builds. | ||
|
||
All checks and tests are passing on win-builder, Travis, R-hub, and my two local machines. | ||
In this specific case, the server software (that our package calls) had | ||
accidentally released a backwards-incompatible change that our tests caught | ||
on the dev server, fortunately before it was released to production servers. | ||
We are grateful that CRAN helped alert everyone to the problem, but we do not | ||
wish to further burden Brian and the rest of the CRAN team as you | ||
graciously donate to the community. | ||
|
||
We just made another modification (related to the previous rejections this week) to account for different sorting orders that I assume are related to different platforms. They hadn't appeared in any of our tests. We also changed a `donttest{}` to a `dontrun{}` example and updated an old url in a vignette that were missed in all these test environments. | ||
|
||
I'm sorry these resubmissions have taken more of your time. Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN. -Will Beasley | ||
Thank you for taking the time to review the submission, and please tell me if | ||
there's something else I should do for CRAN. -Will Beasley | ||
|
||
|
||
Test environments | ||
----------------------------------------------- | ||
|
||
1. Local Ubuntu, R 4.0.4 | ||
1. Local Win10, R 4.0.4 Patched | ||
1. [win-builder](https://win-builder.r-project.org/E5QE5o3DKIJF/), development version. | ||
1. [Travis CI](https://travis-ci.org/github/IQSS/dataverse-client-r), Ubuntu 18.04 LTS | ||
1. [R-hub](https://builder.r-hub.io/status/dataverse_0.3.7.tar.gz-76e7f9d49abc47f598fe0d8ddedcc450). | ||
2. Local Win10, R 4.0.4 Patched | ||
3. [win-builder](), development version. | ||
4. [R-hub](https://builder.r-hub.io/status/dataverse_0.3.8.tar.gz-cdb69dcae8044c28a925dae7004f2e66). | ||
5. [GitHub Actions](https://github.com/IQSS/dataverse-client-r/actions) | ||
* os: macOS-latest , r: 'release' | ||
* os: windows-latest , r: 'devel' | ||
* os: windows-latest , r: 'release' | ||
* os: ubuntu-latest , r: 'devel' | ||
* os: ubuntu-latest , r: 'release' | ||
|
||
R CMD check results | ||
----------------------------------------------- | ||
|
||
* No ERRORs or WARNINGs on any builds. | ||
* There are two NOTEs. One about the package being archived, and another about possibly misspelled words "APIs" and "Dataverse"; both spellings are intentional. | ||
* No ERRORs, WARNINGs, or NOTEs on any builds. | ||
|
||
* In the past, there has been a note about possibly misspelled words "APIs" and "Dataverse". If they appear on your machines, both spellings are intentional. |