Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Dataset: add custom terms of use #248

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Jan 30, 2025

What this PR does / why we need it:

Needed for the Dataset Terms Tab, if custom terms are chosen, these additional fields are displayed.

Which issue(s) this PR closes:

Suggestions on how to test this:

Review the code and tests for Get Dataset use case

Is there a release notes update needed for this change?:

Additional documentation:

@ekraffmiller ekraffmiller added SPA.Q1.3 Dataset Page: Terms Tab FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 GREI Re-arch GREI re-architecture-related labels Jan 30, 2025
@ekraffmiller ekraffmiller changed the title feat: add custom terms of use to Dataset model Add custom terms of use to Dataset model Jan 31, 2025
@ekraffmiller ekraffmiller changed the title Add custom terms of use to Dataset model Get Dataset: add custom terms of use Jan 31, 2025
@g-saracca g-saracca self-assigned this Feb 3, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heey, just some minor comments.
To understand this, we need to format all these terms of use data into markdown to show it in a better way in the Dataset page?
I understand we wont need any change in the frontend repo as the default value of keepRawFields is false.

test/environment/.env Outdated Show resolved Hide resolved
@ekraffmiller
Copy link
Contributor Author

Heey, just some minor comments. To understand this, we need to format all these terms of use data into markdown to show it in a better way in the Dataset page? I understand we wont need any change in the frontend repo as the default value of keepRawFields is false.

Good morning, welcome back! Yes, all these fields are text boxes which allow html in the edit form, so they need to be displayed as markdown in the terms tab. In my frontend PR for the terms tab, I'm using the MarkdownComponent to render them.

@ofahimIQSS
Copy link
Contributor

Tests are passing - merging PR

@ofahimIQSS ofahimIQSS merged commit 3ebfc7d into develop Feb 4, 2025
5 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/247-custom-terms-of-use branch February 4, 2025 14:42
@ofahimIQSS ofahimIQSS removed their assignment Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.3 Dataset Page: Terms Tab
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Get Dataset Extension: add Custom Terms and convert to Markdown
3 participants