-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Dataset: add custom terms of use #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heey, just some minor comments.
To understand this, we need to format all these terms of use data into markdown to show it in a better way in the Dataset page?
I understand we wont need any change in the frontend repo as the default value of keepRawFields
is false
.
Good morning, welcome back! Yes, all these fields are text boxes which allow html in the edit form, so they need to be displayed as markdown in the terms tab. In my frontend PR for the terms tab, I'm using the MarkdownComponent to render them. |
fix: remove unneeded environment variable
Tests are passing - merging PR |
What this PR does / why we need it:
Needed for the Dataset Terms Tab, if custom terms are chosen, these additional fields are displayed.
Which issue(s) this PR closes:
Suggestions on how to test this:
Review the code and tests for Get Dataset use case
Is there a release notes update needed for this change?:
Additional documentation: