Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Dataset Extension: add Terms of Use #243

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Jan 21, 2025

What this PR does / why we need it:

For the Dataset Page: Terms of Use tab, we need all the Terms of Use fields associated with the Datset

Which issue(s) this PR closes:

Related Dataverse PRs:

  • Depends on #

Suggestions on how to test this:

Visual code inspection and validate new tests

@ekraffmiller ekraffmiller added FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) GREI Re-arch GREI re-architecture-related SPA.Q1.3 Dataset Page: Terms Tab Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Jan 21, 2025
@ChengShi-1 ChengShi-1 self-requested a review January 24, 2025 01:00
@ChengShi-1 ChengShi-1 self-assigned this Jan 24, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChengShi-1 ChengShi-1 removed their assignment Jan 24, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jan 27, 2025
@ofahimIQSS
Copy link
Contributor

Tests are passing, merging PR

@ofahimIQSS ofahimIQSS removed their assignment Jan 27, 2025
@ofahimIQSS ofahimIQSS merged commit 397bceb into develop Jan 27, 2025
5 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/239-add-terms-of-use branch January 27, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.3 Dataset Page: Terms Tab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Dataset extension: terms of use
3 participants