fix: underscore escape while html transforming #242
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix the bug that the underscore are escaped with backslashes and accumulate.
After investigating, the function
transformHtmlToMarkdown
leads the underscore format problem, for example, input: "test_" would be transformed to "test\_". This error isn't followed with other symbols, only underscore.After I give an underscore to the title, the test information looks like this
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Even though this is a js-dataverse repo PR, the test has to be done on front end SPA page.
Environment Setting: in package.json, change to
"@iqss/dataverse-client-javascript": "v2.0.0-pr242.cbb959e"
, runnpm i
, and runnpm run build
, may need restart docker as well._
, such as[email protected]