Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Collection Items extension - Count per object type #240

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

g-saracca
Copy link
Contributor

What this PR does / why we need it:

Extends the use case to also return by default the count per object type info.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Tests are using image preview from PR 1127, this should be merged after that one is merged.

Suggestions on how to test this:

Visual code inspection and validate new tests

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) SPA.Q4.1 Collection Page: All Filtering Options SPA.Q1 Not related to any specific Q1 feature labels Jan 17, 2025
@cmbz cmbz added the FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) label Jan 30, 2025
@ChengShi-1 ChengShi-1 self-requested a review February 3, 2025 23:31
@g-saracca
Copy link
Contributor Author

g-saracca commented Feb 4, 2025

Ready for Review, I just update test environment from Github Registry Dataverse Image to unstable image from Docker and copy the fix from Ellen from her PR about metadata blocks length assertions changes.

Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Approve

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependent dataverse PR is merged, so we could dismiss the env. change.

@ofahimIQSS
Copy link
Contributor

tests are passing, IQSS/dataverse#11138 has already been merged.
Merging PR

@ofahimIQSS ofahimIQSS merged commit 4f3d824 into develop Feb 4, 2025
5 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/233-count-per-object-extension branch February 4, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1 Not related to any specific Q1 feature SPA.Q4.1 Collection Page: All Filtering Options
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Get Collection Items extension - count per object
4 participants