-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Collection Items extension - Count per object type #240
Conversation
Ready for Review, I just update test environment from Github Registry Dataverse Image to unstable image from Docker and copy the fix from Ellen from her PR about metadata blocks length assertions changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Approve
test/environment/.env
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependent dataverse PR is merged, so we could dismiss the env. change.
tests are passing, IQSS/dataverse#11138 has already been merged. |
What this PR does / why we need it:
Extends the use case to also return by default the count per object type info.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Tests are using image preview from PR 1127, this should be merged after that one is merged.
Suggestions on how to test this:
Visual code inspection and validate new tests